[BUG] custom-logo links are broken for doc deployments with a path #1203
Milestone
Comments
|
OK, my suggestion won't work for navigating to sub-pages (like in "Additional documentation"). For each hierarchy an adapted relative path is required. For instance, one level down we have to add For the surrounding link to the index.html this is somehow done already (copied from browser console): <a href="../index.html" data-type="index-link">
<img alt="" class="img-responsive" data-type="custom-logo" src="/images/my-custom-logo.png">
</a>Could the generation of <a href="../index.html" data-type="index-link">
<img alt="" class="img-responsive" data-type="custom-logo" src="../images/my-custom-logo.png">
</a> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The closed fix for #1147 (custom-logo links are broken for child content) does not allow a proper deployment of generated documentation under a path. I assume
@compodoc/compodoc v1.1.18(the one we use now) includes the fix.When we deploy the generated docs we use a path, e.g.
barlike inhttps://foo.com/bar/index.htmlto access our docs. If we do that the custom logo is not shown at all (not even on the root page of docs).compodoc/src/templates/partials/menu.hbs
Line 20 in db47436
The fix done now expects images at root like
https://foo.com/images/my-custom-logo.pnginstead ofhttps://foo.com/bar/images/my-custom-logo.png. Pls could you add a dot in front of/images/to make it relative (which then works also for path-based deployments):Thx!
The text was updated successfully, but these errors were encountered: