Output more warnings about plugins being disabled to hint that it may cause problems, fixes #11839 (#11842)

Seldaek · web-flow · commit 690fe716c5d0 · 2024-02-09T11:56:25.000+01:00
diff --git a/src/Composer/Console/Application.php b/src/Composer/Console/Application.php
@@ -220,7 +220,7 @@ public function doRun(InputInterface $input, OutputInterface $output): int
 
         // Clobber sudo credentials if COMPOSER_ALLOW_SUPERUSER is not set before loading plugins
         if ($needsSudoCheck) {
-            $isNonAllowedRoot = function_exists('posix_getuid') && posix_getuid() === 0;
+            $isNonAllowedRoot = $this->isRunningAsRoot();
 
             if ($isNonAllowedRoot) {
                 if ($uid = (int) Platform::getEnv('SUDO_UID')) {
@@ -476,6 +476,12 @@ private function hintCommonErrors(\Throwable $exception, OutputInterface $output
             $io->writeError('<error>Check https://getcomposer.org/doc/06-config.md#process-timeout for details</error>', true, IOInterface::QUIET);
         }
 
+        if ($this->getDisablePluginsByDefault() && $this->isRunningAsRoot() && !$this->io->isInteractive()) {
+            $io->writeError('<error>Plugins have been disabled automatically as you are running as root, this may be the cause of the following exception. See also https://getcomposer.org/root</error>', true, IOInterface::QUIET);
+        } elseif ($exception instanceof CommandNotFoundException && $this->getDisablePluginsByDefault()) {
+            $io->writeError('<error>Plugins have been disabled, which may be why some commands are missing, unless you made a typo</error>', true, IOInterface::QUIET);
+        }
+
         $hints = HttpDownloader::getExceptionHints($exception);
         if (null !== $hints && count($hints) > 0) {
             foreach ($hints as $hint) {
@@ -678,4 +684,9 @@ private function getUseParentDirConfigValue()
 
         return $config->get('use-parent-dir');
     }
+
+    private function isRunningAsRoot(): bool
+    {
+        return function_exists('posix_getuid') && posix_getuid() === 0;
+    }
 }
diff --git a/src/Composer/Installer/InstallationManager.php b/src/Composer/Installer/InstallationManager.php
@@ -94,8 +94,8 @@ public function removeInstaller(InstallerInterface $installer): void
     /**
      * Disables plugins.
      *
-     * We prevent any plugins from being instantiated by simply
-     * deactivating the installer for them. This ensure that no third-party
+     * We prevent any plugins from being instantiated by
+     * disabling the PluginManager. This ensures that no third-party
      * code is ever executed.
      */
     public function disablePlugins(): void
@@ -105,7 +105,7 @@ public function disablePlugins(): void
                 continue;
             }
 
-            unset($this->installers[$i]);
+            $installer->disablePlugins();
         }
     }
 
diff --git a/src/Composer/Installer/PluginInstaller.php b/src/Composer/Installer/PluginInstaller.php
@@ -43,6 +43,11 @@ public function supports(string $packageType)
         return $packageType === 'composer-plugin' || $packageType === 'composer-installer';
     }
 
+    public function disablePlugins(): void
+    {
+        $this->getPluginManager()->disablePlugins();
+    }
+
     /**
      * @inheritDoc
      */
diff --git a/src/Composer/Plugin/PluginManager.php b/src/Composer/Plugin/PluginManager.php
@@ -153,6 +153,7 @@ public function getGlobalComposer(): ?PartialComposer
     public function registerPackage(PackageInterface $package, bool $failOnMissingClasses = false, bool $isGlobalPlugin = false): void
     {
         if ($this->arePluginsDisabled($isGlobalPlugin ? 'global' : 'local')) {
+            $this->io->writeError('<warning>The "'.$package->getName().'" plugin was not loaded as plugins are disabled.</warning>');
             return;
         }
 
@@ -656,6 +657,14 @@ public function arePluginsDisabled($type)
         return $this->disablePlugins === true || $this->disablePlugins === $type;
     }
 
+    /**
+     * @internal
+     */
+    public function disablePlugins(): void
+    {
+        $this->disablePlugins = true;
+    }
+
     /**
      * @internal
      */

Original file line number	Diff line number	Diff line change
`@@ -94,8 +94,8 @@ public function removeInstaller(InstallerInterface $installer): void`
`94`	`94`	`/**`
`95`	`95`	`* Disables plugins.`
`96`	`96`	`*`
`97`		`- * We prevent any plugins from being instantiated by simply`
`98`		`- * deactivating the installer for them. This ensure that no third-party`
	`97`	`+ * We prevent any plugins from being instantiated by`
	`98`	`+ * disabling the PluginManager. This ensures that no third-party`
`99`	`99`	`* code is ever executed.`
`100`	`100`	`*/`
`101`	`101`	`public function disablePlugins(): void`
`@@ -105,7 +105,7 @@ public function disablePlugins(): void`
`105`	`105`	`continue;`
`106`	`106`	`}`
`107`	`107`
`108`		`- unset($this->installers[$i]);`
	`108`	`+ $installer->disablePlugins();`
`109`	`109`	`}`
`110`	`110`	`}`
`111`	`111`