Fix handling of inline-update-constraints with refs or stability flags, fixes #9847

Seldaek · Seldaek · commit a844fce23ecf · 2021-05-04T14:14:57.000+02:00
diff --git a/src/Composer/Command/UpdateCommand.php b/src/Composer/Command/UpdateCommand.php
@@ -16,6 +16,7 @@
 use Composer\DependencyResolver\Request;
 use Composer\Installer;
 use Composer\IO\IOInterface;
+use Composer\Package\Loader\RootPackageLoader;
 use Composer\Plugin\CommandEvent;
 use Composer\Plugin\PluginEvents;
 use Composer\Package\Version\VersionParser;
@@ -139,8 +140,9 @@ protected function execute(InputInterface $input, OutputInterface $output)
             }
         }
 
-        $rootRequires = $composer->getPackage()->getRequires();
-        $rootDevRequires = $composer->getPackage()->getDevRequires();
+        $rootPackage = $composer->getPackage();
+        $rootRequires = $rootPackage->getRequires();
+        $rootDevRequires = $rootPackage->getDevRequires();
         foreach ($reqs as $package => $constraint) {
             if (isset($rootRequires[$package])) {
                 $rootRequires[$package] = $this->appendConstraintToLink($rootRequires[$package], $constraint);
@@ -150,8 +152,10 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 throw new \UnexpectedValueException('Only root package requirements can receive temporary constraints and '.$package.' is not one');
             }
         }
-        $composer->getPackage()->setRequires($rootRequires);
-        $composer->getPackage()->setDevRequires($rootDevRequires);
+        $rootPackage->setRequires($rootRequires);
+        $rootPackage->setDevRequires($rootDevRequires);
+        $rootPackage->setReferences(RootPackageLoader::extractReferences($reqs, $rootPackage->getReferences()));
+        $rootPackage->setStabilityFlags(RootPackageLoader::extractStabilityFlags($reqs, $rootPackage->getMinimumStability(), $rootPackage->getStabilityFlags()));
 
         if ($input->getOption('interactive')) {
             $packages = $this->getPackagesInteractively($io, $input, $output, $composer, $packages);
diff --git a/src/Composer/Package/Loader/RootPackageLoader.php b/src/Composer/Package/Loader/RootPackageLoader.php
@@ -130,8 +130,8 @@ public function load(array $config, $class = 'Composer\Package\RootPackage', $cw
                     $links[$link->getTarget()] = $link->getConstraint()->getPrettyString();
                 }
                 $aliases = $this->extractAliases($links, $aliases);
-                $stabilityFlags = $this->extractStabilityFlags($links, $stabilityFlags, $realPackage->getMinimumStability());
-                $references = $this->extractReferences($links, $references);
+                $stabilityFlags = self::extractStabilityFlags($links, $realPackage->getMinimumStability(), $stabilityFlags);
+                $references = self::extractReferences($links, $references);
 
                 if (isset($links[$config['name']])) {
                     throw new \RuntimeException(sprintf('Root package \'%s\' cannot require itself in its composer.json' . PHP_EOL .
@@ -189,7 +189,10 @@ private function extractAliases(array $requires, array $aliases)
         return $aliases;
     }
 
-    private function extractStabilityFlags(array $requires, array $stabilityFlags, $minimumStability)
+    /**
+     * @internal
+     */
+    public static function extractStabilityFlags(array $requires, $minimumStability, array $stabilityFlags)
     {
         $stabilities = BasePackage::$stabilities;
         $minimumStability = $stabilities[$minimumStability];
@@ -242,7 +245,10 @@ private function extractStabilityFlags(array $requires, array $stabilityFlags, $
         return $stabilityFlags;
     }
 
-    private function extractReferences(array $requires, array $references)
+    /**
+     * @internal
+     */
+    public static function extractReferences(array $requires, array $references)
     {
         foreach ($requires as $reqName => $reqVersion) {
             $reqVersion = preg_replace('{^([^,\s@]+) as .+$}', '$1', $reqVersion);
