Add support for Application::setCatchErrors in symfony 6.4+, refs symfony/symfony#50420

Seldaek · Seldaek · commit f4738d97b787 · 2023-07-28T19:33:33.000+02:00
diff --git a/src/Composer/Console/Application.php b/src/Composer/Console/Application.php
@@ -87,6 +87,10 @@ class Application extends BaseApplication
 
     public function __construct(string $name = 'Composer', string $version = '')
     {
+        if (method_exists($this, 'setCatchErrors')) {
+            $this->setCatchErrors(true);
+        }
+
         static $shutdownRegistered = false;
         if ($version === '') {
             $version = Composer::getVersion();
@@ -395,9 +399,10 @@ function_exists('php_uname') ? php_uname('s') . ' / ' . php_uname('r') : 'Unknow
 
             $this->hintCommonErrors($e, $output);
 
-            // symfony/console does not handle \Error subtypes so we have to renderThrowable ourselves
+            // symfony/console <6.4 does not handle \Error subtypes so we have to renderThrowable ourselves
             // instead of rethrowing those for consumption by the parent class
-            if (!$e instanceof \Exception) {
+            // can be removed when Composer supports PHP 8.1+
+            if (!method_exists($this, 'setCatchErrors') && !$e instanceof \Exception) {
                 if ($output instanceof ConsoleOutputInterface) {
                     $this->renderThrowable($e, $output->getErrorOutput());
                 } else {
diff --git a/src/Composer/EventDispatcher/EventDispatcher.php b/src/Composer/EventDispatcher/EventDispatcher.php
@@ -277,6 +277,9 @@ protected function doDispatch(Event $event)
 
                     $app = new Application();
                     $app->setCatchExceptions(false);
+                    if (method_exists($app, 'setCatchErrors')) {
+                        $app->setCatchErrors(false);
+                    }
                     $app->setAutoExit(false);
                     $cmd = new $className($event->getName());
                     $app->add($cmd);
diff --git a/tests/Composer/Test/DocumentationTest.php b/tests/Composer/Test/DocumentationTest.php
@@ -53,6 +53,9 @@ public static function provideCommandCases(): \Generator
     {
         $application = new Application();
         $application->setAutoExit(false);
+        if (method_exists($application, 'setCatchErrors')) {
+            $application->setCatchErrors(false);
+        }
         $application->setCatchExceptions(false);
 
         $description = new ApplicationDescription($application);
diff --git a/tests/Composer/Test/TestCase.php b/tests/Composer/Test/TestCase.php
@@ -198,6 +198,9 @@ public function getApplicationTester(): ApplicationTester
         $application = new Application();
         $application->setAutoExit(false);
         $application->setCatchExceptions(false);
+        if (method_exists($application, 'setCatchErrors')) {
+            $application->setCatchErrors(false);
+        }
 
         return new ApplicationTester($application);
     }

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,9 @@ public static function provideCommandCases(): \Generator`
`53`	`53`	`{`
`54`	`54`	`$application = new Application();`
`55`	`55`	`$application->setAutoExit(false);`
	`56`	`+ if (method_exists($application, 'setCatchErrors')) {`
	`57`	`+ $application->setCatchErrors(false);`
	`58`	`+ }`
`56`	`59`	`$application->setCatchExceptions(false);`
`57`	`60`
`58`	`61`	`$description = new ApplicationDescription($application);`
Original file line number	Diff line number	Diff line change
`@@ -198,6 +198,9 @@ public function getApplicationTester(): ApplicationTester`
`198`	`198`	`$application = new Application();`
`199`	`199`	`$application->setAutoExit(false);`
`200`	`200`	`$application->setCatchExceptions(false);`
	`201`	`+ if (method_exists($application, 'setCatchErrors')) {`
	`202`	`+ $application->setCatchErrors(false);`
	`203`	`+ }`
`201`	`204`
`202`	`205`	`return new ApplicationTester($application);`
`203`	`206`	`}`