Platform::getCwd() will throw an exception before we get to Platform::realpath() if there's a problem

The preceding Filesystem::ensureDirectoryExists() call suggests Platform::realpath() will be successful

file_exists() was just called (previous line) so we can assume that $dir is a valid path, and omit the try/catch

Tested in: 89d71b2

First use:

Platform::getCwd() will return a valid path or will throw RuntimeException itself

% php -r "echo getcwd();"    
/Users/brianhenry/Sites/composer

% php -r "echo realpath('');"
/Users/brianhenry/Sites/composer

% php -r "echo __DIR__;" 
/Users/brianhenry/Sites/composer

% php -r "include './vendor/autoload.php'; echo \Composer\Util\Platform::getCwd();"
/Users/brianhenry/Sites/composer

Second use:

$this->config->get('home') comes from Factory::getHomeDir() suggesting it could be an invalid value passed as the COMPOSER_HOME environmental variable, but debugging steps:

• GlobalCommand::run()
• GlobalCommand::prepareSubcommandInput()
• FileSystem::ensureDirectoryExists()

and throws RuntimeException "does not exist and could not be created" for $config->get('home').

So in both cases, Platform::realpath() will never be called with an invalid path.

Added a test in 8184e1e because there was none covering that path yet.

The original logic is ~if we have $realDir, let's create $signalHandler, then we'll unset that later:

Now if ::realpath() throws an exception, it skips the $signalHandler line and continues as normal.

I guess the signal handler intercepts ctrl-c etc to delete the directory before exiting, so it's not needed if there is no directory to delete.

Covered by existing tests InitCommandTest::testRunGuessNameFromDirSanitizesDir() and ::testInteractiveRun()

simple-phpunit --filter="testRunGuessNameFromDirSanitizesDir|testInteractiveRun"

• TODO: more thoroughly test here

This preserves current behaviour but isn't great IMO.

Yeah I'd say that is probably ok to expect the realpath to work here and remove the catch.

There are no unit tests on this (large) function. But this reads right to me, better even.

Original:

$extraFiles[$file] = realpath($file);
if (!file_exists($file)) {
  throw new \RuntimeException('Extra file listed is missing from the filesystem: '.$file);
}

new:

try {
    $extraFiles[$file] = Platform::realpath($file);
} catch (\RuntimeException $e) {
    throw new \RuntimeException('Extra file listed is missing from the filesystem: '.$file);
}

Potentially just:

$extraFiles[$file] = Platform::realpath($file);

which would also throw a RuntimeException but with a slightly different message

This one too I'd probably try/catch and use $home = Platform::realpath('/') as fallback. Because otherwise if HOME points to an invalid dir somehow this will blow up in bad ways for people, and this is a fairly hot code path so I'd rather not risk major issues.

The is_dir() check on the same line assures us that ::realpath() will succeed.

is_dir($basePath) is performed a few lines above. This line cannot be reached unless $basePath is a directory.