handle_command no longer returns

hjwp · hjwp · commit 1898b2c2bdd2 · 2024-03-01T15:05:35.000Z
diff --git a/src/allocation/entrypoints/flask_app.py b/src/allocation/entrypoints/flask_app.py
@@ -31,8 +31,7 @@ def allocate_endpoint():
             request.json["orderid"], request.json["sku"], request.json["qty"]
         )
         uow = unit_of_work.SqlAlchemyUnitOfWork()
-        results = messagebus.handle(cmd, uow)
-        batchref = results.pop(0)
+        messagebus.handle(cmd, uow)
     except InvalidSku as e:
         return {"message": str(e)}, 400
 
diff --git a/src/allocation/service_layer/messagebus.py b/src/allocation/service_layer/messagebus.py
@@ -13,22 +13,16 @@
 Message = Union[commands.Command, events.Event]
 
 
-def handle(
-    message: Message,
-    uow: unit_of_work.AbstractUnitOfWork,
-):
-    results = []
+def handle(message: Message, uow: unit_of_work.AbstractUnitOfWork):
     queue = [message]
     while queue:
         message = queue.pop(0)
         if isinstance(message, events.Event):
             handle_event(message, queue, uow)
         elif isinstance(message, commands.Command):
-            cmd_result = handle_command(message, queue, uow)
-            results.append(cmd_result)
+            handle_command(message, queue, uow)
         else:
             raise Exception(f"{message} was not an Event or Command")
-    return results
 
 
 def handle_event(
@@ -54,9 +48,8 @@ def handle_command(
     logger.debug("handling command %s", command)
     try:
         handler = COMMAND_HANDLERS[type(command)]
-        result = handler(command, uow=uow)
+        handler(command, uow=uow)
         queue.extend(uow.collect_new_events())
-        return result
     except Exception:
         logger.exception("Exception handling command %s", command)
         raise

Original file line number	Diff line number	Diff line change
`@@ -31,8 +31,7 @@ def allocate_endpoint():`
`31`	`31`	`request.json["orderid"], request.json["sku"], request.json["qty"]`
`32`	`32`	`)`
`33`	`33`	`uow = unit_of_work.SqlAlchemyUnitOfWork()`
`34`		`- results = messagebus.handle(cmd, uow)`
`35`		`- batchref = results.pop(0)`
	`34`	`+ messagebus.handle(cmd, uow)`
`36`	`35`	`except InvalidSku as e:`
`37`	`36`	`return {"message": str(e)}, 400`
`38`	`37`