refactor: remove eventlet testing

nedbat · nedbat · commit e2f3dec58e27 · 2026-04-16T18:35:15.000-04:00
See eventlet/eventlet#1089
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -16,7 +16,7 @@ repos:
         exclude: "stress_phystoken|\\.py,cover$"
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.15.10
+    rev: v0.15.11
     hooks:
       - id: ruff-format
 
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -23,7 +23,8 @@ upgrading your version of coverage.py.
 Unreleased
 ----------
 
-Nothing yet.
+- We are no longer testing eventlet support. Eventlet issues stern deprecation
+  warnings that break our tests. Our support code is still there.
 
 
 .. start-releases
diff --git a/requirements/light-threads.in b/requirements/light-threads.in
@@ -5,7 +5,6 @@
 
 # The light-threads packages we test against.
 
-eventlet
 gevent
 greenlet
 
diff --git a/requirements/light-threads.pip b/requirements/light-threads.pip
@@ -88,14 +88,6 @@ cffi==2.0.0 \
     # via
     #   -r requirements/light-threads.in
     #   gevent
-dnspython==2.8.0 \
-    --hash=sha256:01d9bbc4a2d76bf0db7c1f729812ded6d912bd318d3b1cf81d30c0f845dbf3af \
-    --hash=sha256:181d3c6996452cb1189c4046c61599b84a5a86e099562ffde77d26984ff26d0f
-    # via eventlet
-eventlet==0.41.0 \
-    --hash=sha256:35df85f0ccd3e73effb6fd9f1ceae46b500b966c7da1817289c323a307bd397b \
-    --hash=sha256:bc22396093cb4119ff7007776be6a5348a613ccd42eeb0f9519853a6efcbcabe
-    # via -r requirements/light-threads.in
 gevent==25.9.1 \
     --hash=sha256:012a44b0121f3d7c800740ff80351c897e85e76a7e4764690f35c5ad9ec17de5 \
     --hash=sha256:03c74fec58eda4b4edc043311fca8ba4f8744ad1632eb0a41d5ec25413581975 \
@@ -197,7 +189,6 @@ greenlet==3.3.2 \
     --hash=sha256:e3cb43ce200f59483eb82949bf1835a99cf43d7571e900d7c8d5c62cdf25d2f9
     # via
     #   -r requirements/light-threads.in
-    #   eventlet
     #   gevent
 pycparser==3.0 ; implementation_name != 'PyPy' \
     --hash=sha256:600f49d217304a5902ac3c37e1281c9fe94e4d0489de643a9504c5cdfdfc6b29 \
diff --git a/tests/test_concurrency.py b/tests/test_concurrency.py
@@ -34,11 +34,6 @@
 
 # These libraries aren't always available, we'll skip tests if they aren't.
 
-try:
-    import eventlet
-except ImportError:
-    eventlet = None
-
 try:
     import gevent
 except ImportError:
@@ -151,12 +146,6 @@ def sum_range(limit):
     import queue
     """
 
-# Import the things to use eventlet.
-EVENTLET = """
-    import eventlet.green.threading as threading
-    import eventlet.queue as queue
-    """
-
 # Import the things to use gevent.
 GEVENT = """
     from gevent import monkey
@@ -266,14 +255,6 @@ def test_threads_simple_code(self) -> None:
         code = SIMPLE.format(QLIMIT=self.QLIMIT)
         self.try_some_code(code, "thread", threading)
 
-    def test_eventlet(self) -> None:
-        code = (EVENTLET + SUM_RANGE_Q + PRINT_SUM_RANGE).format(QLIMIT=self.QLIMIT)
-        self.try_some_code(code, "eventlet", eventlet)
-
-    def test_eventlet_simple_code(self) -> None:
-        code = SIMPLE.format(QLIMIT=self.QLIMIT)
-        self.try_some_code(code, "eventlet", eventlet)
-
     # https://github.com/coveragepy/coveragepy/issues/663
     @pytest.mark.skipif(env.WINDOWS, reason="gevent has problems on Windows: #663")
     def test_gevent(self) -> None:
@@ -306,6 +287,10 @@ def test_greenlet_simple_code(self) -> None:
         code = SIMPLE.format(QLIMIT=self.QLIMIT)
         self.try_some_code(code, "greenlet", greenlet)
 
+    # The code in tracer.c that went with this test doesn't seem particular to
+    # eventlet. I don't want to remove this test, but I don't know how to
+    # rewrite it to demonstrate the original problem without eventlet.
+    @pytest.mark.skip(reason="We don't test eventlet; don't know how to rewrite this test.")
     def test_bug_330(self) -> None:
         BUG_330 = """\
             from weakref import WeakKeyDictionary
@@ -322,6 +307,7 @@ def do():
             eventlet.sleep(.1)
             print(len(gts))
             """
+        eventlet = glob  # quiet linters on the next line.
         self.try_some_code(BUG_330, "eventlet", eventlet, "0\n")
 
     # Sometimes a test fails due to inherent randomness. Try more times.
@@ -382,12 +368,12 @@ def test_bad_concurrency_in_config(self) -> None:
             self.command_line("run prog.py")
 
     def test_no_multiple_light_concurrency(self) -> None:
-        with pytest.raises(ConfigError, match="Conflicting concurrency settings: eventlet, gevent"):
-            self.command_line("run --concurrency=gevent,eventlet prog.py")
+        with pytest.raises(ConfigError, match="Conflicting concurrency settings: gevent, greenlet"):
+            self.command_line("run --concurrency=gevent,greenlet prog.py")
 
     def test_no_multiple_light_concurrency_in_config(self) -> None:
-        self.make_file(".coveragerc", "[run]\nconcurrency = gevent, eventlet\n")
-        with pytest.raises(ConfigError, match="Conflicting concurrency settings: eventlet, gevent"):
+        self.make_file(".coveragerc", "[run]\nconcurrency = gevent, greenlet\n")
+        with pytest.raises(ConfigError, match="Conflicting concurrency settings: gevent, greenlet"):
             self.command_line("run prog.py")
 
     def test_multiprocessing_needs_config_file(self) -> None:
@@ -398,7 +384,7 @@ def test_multiprocessing_needs_config_file(self) -> None:
 class WithoutConcurrencyModuleTest(CoverageTest):
     """Tests of what happens if the requested concurrency isn't installed."""
 
-    @pytest.mark.parametrize("module", ["eventlet", "gevent", "greenlet"])
+    @pytest.mark.parametrize("module", ["gevent", "greenlet"])
     def test_missing_module(self, module: str) -> None:
         self.make_file("prog.py", "a = 1")
         sys.modules[module] = None  # type: ignore[assignment]
@@ -546,23 +532,6 @@ def test_multiprocessing_append(self, start_method: str) -> None:
             start_method=start_method,
         )
 
-    def test_multiprocessing_and_gevent(self, start_method: str) -> None:
-        nprocs = 3
-        upto = 30
-        code = (SUM_RANGE_WORK + EVENTLET + SUM_RANGE_Q + MULTI_CODE).format(
-            NPROCS=nprocs, UPTO=upto
-        )
-        total = sum(sum(range((x + 1) * 100)) for x in range(upto))
-        expected_out = f"{nprocs} pids, total = {total}"
-        self.try_multiprocessing_code(
-            code,
-            expected_out,
-            eventlet,
-            nprocs,
-            concurrency="multiprocessing,eventlet",
-            start_method=start_method,
-        )
-
     @pytest.mark.skipif(
         not testenv.CAN_MEASURE_BRANCHES, reason="Can't measure branches with this core"
     )
diff --git a/tests/test_config.py b/tests/test_config.py
@@ -86,7 +86,7 @@ def test_toml_config_file(self, filename: str) -> None:
             [tool.somethingelse]
             authors = ["Joe D'Ávila <joe@gmail.com>"]
             [tool.coverage.run]
-            concurrency = ["thread", "eventlet"]
+            concurrency = ["thread", "gevent"]
             timid = true
             data_file = ".hello_kitty.data"
             plugins = ["plugins.a_plugin"]
@@ -102,7 +102,7 @@ def test_toml_config_file(self, filename: str) -> None:
         cov = coverage.Coverage()
         assert cov.config.timid
         assert not cov.config.branch
-        assert cov.config.concurrency == ["thread", "eventlet"]
+        assert cov.config.concurrency == ["thread", "gevent"]
         assert cov.config.data_file == ".hello_kitty.data"
         assert cov.config.plugins == ["plugins.a_plugin"]
         assert cov.config.precision == 3
