rename helper fn to toELVersion

wagoodman · wagoodman · commit 5ea1d784640f · 2021-06-04T09:38:15.000-04:00
Signed-off-by: Alex Goodman &lt;alex.goodman@anchore.com&gt;
diff --git a/syft/pkg/cataloger/rpmdb/parse_rpmdb.go b/syft/pkg/cataloger/rpmdb/parse_rpmdb.go
@@ -62,7 +62,7 @@ func parseRpmDB(resolver source.FilePathResolver, dbLocation source.Location, re
 
 		p := pkg.Package{
 			Name:         entry.Name,
-			Version:      toElVersion(metadata),
+			Version:      toELVersion(metadata),
 			Locations:    []source.Location{dbLocation},
 			FoundBy:      catalogerName,
 			Type:         pkg.RpmPkg,
@@ -78,11 +78,11 @@ func parseRpmDB(resolver source.FilePathResolver, dbLocation source.Location, re
 
 // The RPM naming scheme is [name]-[version]-[release]-[arch], where version is implicitly expands to [epoch]:[version].
 // RPM version comparison depends on comparing at least the version and release fields together as a subset of the
-// naming scheme. This toElVersion function takes a RPM DB package information and converts it into a minimally comparable
+// naming scheme. This toELVersion function takes a RPM DB package information and converts it into a minimally comparable
 // version string, containing epoch (optional), version, and release information. Epoch is an optional field and can be
 // assumed to be 0 when not provided for comparison purposes, however, if the underlying RPM DB entry does not have
 // an epoch specified it would be slightly disingenuous to display a value of 0.
-func toElVersion(metadata pkg.RpmdbMetadata) string {
+func toELVersion(metadata pkg.RpmdbMetadata) string {
 	if metadata.Epoch != nil {
 		return fmt.Sprintf("%d:%s-%s", *metadata.Epoch, metadata.Version, metadata.Release)
 	}
diff --git a/syft/pkg/cataloger/rpmdb/parse_rpmdb_test.go b/syft/pkg/cataloger/rpmdb/parse_rpmdb_test.go
@@ -199,7 +199,7 @@ func TestToElVersion(t *testing.T) {
 
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
-			assert.Equal(t, test.expected, toElVersion(test.entry))
+			assert.Equal(t, test.expected, toELVersion(test.entry))
 		})
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,7 @@ func TestToElVersion(t *testing.T) {`
`199`	`199`
`200`	`200`	`for _, test := range tests {`
`201`	`201`	`t.Run(test.name, func(t *testing.T) {`
`202`		`- assert.Equal(t, test.expected, toElVersion(test.entry))`
	`202`	`+ assert.Equal(t, test.expected, toELVersion(test.entry))`
`203`	`203`	`})`
`204`	`204`	`}`
`205`	`205`	`}`