Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixes for pylint compliance #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 4, 2016
Merged

Conversation

tkruse
Copy link
Contributor

@tkruse tkruse commented May 12, 2016

This PR adds pylint to the travis build, and makes code changes to make pylint pass

@theandrewdavis theandrewdavis merged commit ceb199d into cpplint:master Jul 4, 2016
@theandrewdavis
Copy link
Contributor

There was a change in this PR to the way stderr is patched that caused cpplint to throw an error in python2 and python3:

sys.stderr = codecs.StreamReader(sys.stderr, codecs.getreader('utf8'), codecs.getwriter('utf8'), 'replace')

I checked out the codecs documentation and it didn't seem valid so I removed it. Not sure if you were looking at the StreamReaderWriter docs instead, but let me know if I'm missing something here.

@tkruse
Copy link
Contributor Author

tkruse commented Jul 4, 2016

I see, that's part of d3d4380. I wanted to restore similarity to the google codebase. It should work for Python2, not Python3. Also see google/styleguide@b511d7d

@tkruse tkruse deleted the fixes2 branch July 4, 2016 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants