Regression tests #13
Merged
Regression tests #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2016
|
This PR seems to have removed the pylint checking you added earlier. I'm guessing that wasn't intended, so I left it in |
|
Oh, I see now that you are replacing pylint with pyflakes and that's why the pylint was removed. I'm guessing you intended pyflakes to run in travis, so I changed the |
|
Honestly I cannot remember, but it would be more like me to try and have both pylint and pyflakes... |
|
Seemssome things got lost during rebases, here is the original commit: |
|
Yes, I suggest to have all 3 on travis:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new test for regressions, running cpplint against some samples I pulled from here and there, and making sure output stays the same. In some cases, python2 and python3 will use different sorting for sets and dicts, in those cases output should be sorted to make wiritng tests pass (and also for usability).