Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Differentiate namespace headers #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

tkruse
Copy link
Contributor

@tkruse tkruse commented Feb 28, 2019

includes and supercedes #92

@tkruse
Copy link
Contributor Author

tkruse commented Feb 28, 2019

@geoffviola : thanks for the report. I see no problem with this. Trying out a bit with a real file, I see that like many checks in cpplint, this one is not very robust:

// not ok
namespace {

vs.

// ok
namespace
{

due to the nature of checking the file line-by-line.

Anyway, that's just a side-note. I think this can be included in the next release.

@tkruse tkruse changed the base branch from master to develop June 22, 2020 01:28
@tkruse tkruse closed this Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants