In addition to fast locking implementation issue, I recalled that there are three separate locks in our memory pool. We need to investigate the implications when switching to free-threaded python - I haven't looked in detail but I guess deadlock could happen depending on the order of locking.

Lines 1173 to 1195 in 541b9c6

    
           # Map from memory pointer of the chunk (intptr_t) to the corresponding 
        
           # Chunk object. All chunks currently allocated to the application from 
        
           # this pool are stored. 
        
           # `_in_use_lock` must be acquired to access it. 
        
           dict _in_use 
        
           # Map from stream identifier to its arena for the stream. 
        
           # `_free_lock` must be acquired to access it. 
        
           dict _arenas 
        
           # Number of total bytes actually allocated on GPU. 
        
           # `_total_bytes_lock` must be acquired to access it. 
        
           size_t _total_bytes 
        
           # Upper limit of the amount to be allocated by this pool. 
        
           # `_total_bytes_lock` must be acquired to access it. 
        
           size_t _total_bytes_limit 
        
           object __weakref__ 
        
           object _weakref 
        
           object _free_lock 
        
           object _in_use_lock 
        
           object _total_bytes_lock

	# Map from memory pointer of the chunk (intptr_t) to the corresponding
	# Chunk object. All chunks currently allocated to the application from
	# this pool are stored.
	# `_in_use_lock` must be acquired to access it.
	dict _in_use

	# Map from stream identifier to its arena for the stream.
	# `_free_lock` must be acquired to access it.
	dict _arenas

	# Number of total bytes actually allocated on GPU.
	# `_total_bytes_lock` must be acquired to access it.
	size_t _total_bytes

	# Upper limit of the amount to be allocated by this pool.
	# `_total_bytes_lock` must be acquired to access it.
	size_t _total_bytes_limit

	object __weakref__
	object _weakref
	object _free_lock
	object _in_use_lock
	object _total_bytes_lock

Uh oh!

Support free-threaded build Python #8998

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions