Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 12bd98e

Browse files
committed
improved the update rows test
1 parent e0d1392 commit 12bd98e

File tree

1 file changed

+11
-11
lines changed
  • frameworks/keyed/targetjs/src

1 file changed

+11
-11
lines changed

frameworks/keyed/targetjs/src/main.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,7 @@ App(new TModel("benchmark", {
3333
return new TModel('update', {
3434
onClick() {
3535
const rows = this.getParent().findChild('rows');
36-
if (!rows.val('rowElements')) {
37-
rows.activateTarget('rowElements');
38-
}
39-
rows.activateTarget('updateEvery10thRow');
36+
rows.activateTarget('updateEvery10thLink');
4037
}
4138
});
4239
},
@@ -71,7 +68,7 @@ App(new TModel("benchmark", {
7168
return buildData(this._buildData);
7269
},
7370
_createRows() {
74-
this.deleteTargetValue('rowElements');
71+
this.deleteTargetValue('selectLinks');
7572
this.prevTargetValue.forEach((data, index) => {
7673
const $tr = this.val('rowTemplate').cloneTemplate();
7774
$tr.attr('data-id', `${index}`);
@@ -80,13 +77,16 @@ App(new TModel("benchmark", {
8077
this.$dom.append$Dom($tr);
8178
});
8279
},
83-
_rowElements() {
84-
return this.$dom.queryAll('tr');
80+
_selectLinks() {
81+
const $rows = this.$dom.queryAll('tr');
82+
const links = [];
83+
for (let i = 0; i < $rows.length; i += 10) {
84+
links.push($rows[i].querySelector('.label-cell a'));
85+
}
86+
return links;
8587
},
86-
_updateEvery10thRow() {
87-
for (let i = 0; i < this.prevTargetValue.length; i += 10) {
88-
this.prevTargetValue[i].querySelector('.label-cell a').textContent += ' !!!';
89-
}
88+
_updateEvery10thLink() {
89+
this.prevTargetValue.forEach(link => link.textContent += ' !!!')
9090
},
9191
_swap() {
9292
const rowElements = this._swap.map(id => this.$dom.query(`[data-id="${id}"]`));

0 commit comments

Comments
 (0)