BUG: decref of field title caused segfault

mattip · mattip · commit eda0b3a475ef · 2018-07-05T21:52:30.000-07:00
diff --git a/numpy/core/src/multiarray/mapping.c b/numpy/core/src/multiarray/mapping.c
@@ -1546,7 +1546,6 @@ _get_field_view(PyArrayObject *arr, PyObject *ind, PyArrayObject **view,
                     Py_DECREF(names);
                     return 0;
                 }
-                Py_DECREF(title);
             }
             /* disallow duplicate field indices */
             if (PyDict_Contains(fields, name)) {
diff --git a/numpy/core/tests/test_regression.py b/numpy/core/tests/test_regression.py
@@ -2391,3 +2391,15 @@ def test_dtype_scalar_squeeze(self):
                 squeezed = scvalue.squeeze(axis=axis)
                 assert_equal(squeezed, scvalue)
                 assert_equal(type(squeezed), type(scvalue))
+
+    def test_field_access_by_title(self):
+        # gh-11507
+        s = 'Some long field name'
+        if HAS_REFCOUNT:
+            base = sys.getrefcount(s)
+        t = np.dtype([((s, 'f1'), np.float64)])
+        data = np.zeros(10, t)
+        for i in range(10):
+            v = str(data[['f1']])
+            if HAS_REFCOUNT:
+                assert_(base <= sys.getrefcount(s))

Original file line number	Diff line number	Diff line change
`@@ -1546,7 +1546,6 @@ _get_field_view(PyArrayObject arr, PyObject ind, PyArrayObject **view,`
`1546`	`1546`	`Py_DECREF(names);`
`1547`	`1547`	`return 0;`
`1548`	`1548`	`}`
`1549`		`- Py_DECREF(title);`
`1550`	`1549`	`}`
`1551`	`1550`	`/* disallow duplicate field indices */`
`1552`	`1551`	`if (PyDict_Contains(fields, name)) {`