Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[infra] Consider combining coverage for native_ packages #2170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dcharkes opened this issue Apr 4, 2025 · 1 comment
Open

[infra] Consider combining coverage for native_ packages #2170

dcharkes opened this issue Apr 4, 2025 · 1 comment
Labels
P3 A lower priority bug or feature request package:hooks

Comments

@dcharkes
Copy link
Collaborator

dcharkes commented Apr 4, 2025

Currently, we run coverage for all packages individually. This means that integration tests in package:native_assets_builder don't get counted for package:native_assets_cli.

We don't want to count code that is not covered as dead code if it's not dead when used by another package.
Also, we don't want to write unit tests (which might not do the right thing) just to increase code coverage. Integration tests are more likely to do the right thing.

When we turn the native_ packages into a pub workspace (#1223), we should consider combining the coverage runs into one.

Possible tech to do this:

(Secondly, we should also consider simplifying the CI to run some kind of dart workspace test command for all packages in the workspace, rather than a separate bot doing dart test for each package individually. We always run the bots for all these packages anyway.)

@dcharkes dcharkes added P3 A lower priority bug or feature request package:hooks labels Apr 4, 2025
@dcharkes
Copy link
Collaborator Author

dcharkes commented May 1, 2025

This needs to be implemented in package:coverage first:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 A lower priority bug or feature request package:hooks
Projects
None yet
Development

No branches or pull requests

1 participant