You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we run coverage for all packages individually. This means that integration tests in package:native_assets_builder don't get counted for package:native_assets_cli.
We don't want to count code that is not covered as dead code if it's not dead when used by another package.
Also, we don't want to write unit tests (which might not do the right thing) just to increase code coverage. Integration tests are more likely to do the right thing.
When we turn the native_ packages into a pub workspace (#1223), we should consider combining the coverage runs into one.
(Secondly, we should also consider simplifying the CI to run some kind of dart workspace test command for all packages in the workspace, rather than a separate bot doing dart test for each package individually. We always run the bots for all these packages anyway.)
The text was updated successfully, but these errors were encountered:
Currently, we run coverage for all packages individually. This means that integration tests in
package:native_assets_builder
don't get counted forpackage:native_assets_cli
.We don't want to count code that is not covered as dead code if it's not dead when used by another package.
Also, we don't want to write unit tests (which might not do the right thing) just to increase code coverage. Integration tests are more likely to do the right thing.
When we turn the
native_
packages into a pub workspace (#1223), we should consider combining the coverage runs into one.Possible tech to do this:
(Secondly, we should also consider simplifying the CI to run some kind of
dart workspace test
command for all packages in the workspace, rather than a separate bot doingdart test
for each package individually. We always run the bots for all these packages anyway.)The text was updated successfully, but these errors were encountered: