Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rolls are blocked due to timeouts on Flutter "Linux Web Framework tests" #51056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexmarkov opened this issue Jan 18, 2023 · 4 comments
Closed

Rolls are blocked due to timeouts on Flutter "Linux Web Framework tests" #51056

alexmarkov opened this issue Jan 18, 2023 · 4 comments
Assignees
@nshahan
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. P0 A serious issue requiring immediate resolution

Comments

@alexmarkov
Copy link
Contributor

Dart SDK -> engine rolls are blocked because "Linux Web Framework tests" shard fails with a lot of timeouts.

Example log:

00:00 +0 -1: compiling /b/s/w/ir/x/w/flutter/packages/flutter/test/rendering/sliver_persistent_header_test.dart [E]                                                                                    
  PathNotFoundException: Cannot open file, path = '/b/s/w/ir/x/w/recipe_cleanup/builder/src/out/host_debug_unopt/dart-sdk/lib/dev_compiler/kernel/amd/require.js' (OS Error: No such file or directory, errno = 2)
  dart:io/common.dart 55:9      _checkForErrorResponse
  dart:io/file_impl.dart 364:7  _File.open.<fn>
  dart:async/zone.dart 1406:47  _rootRunUnary
  ===== asynchronous gap ===========================
  dart:io/file_impl.dart 136:5  _FileStream._start.onOpenFile
  

To run this test again: /b/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dart test /b/s/w/ir/x/w/flutter/packages/flutter/test/rendering/sliver_persistent_header_test.dart -p chrome --plain-name 'compiling /b/s/w/ir/x/w/flutter/packages/flutter/test/rendering/sliver_persistent_header_test.dart'

12:00 +0 -2: compiling /b/s/w/ir/x/w/flutter/packages/flutter/test/rendering/positioned_box_test.dart [E]                                                                                              
  TimeoutException after 0:12:00.000000: Test timed out after 12 minutes.
  package:test_api/src/backend/invoker.dart 334:28  Invoker._handleError.<fn>
  dart:async/zone.dart 1390:47                      _rootRun
  dart:async/zone.dart 1300:19                      _CustomZone.run
  package:test_api/src/backend/invoker.dart 332:10  Invoker._handleError
  package:test_api/src/backend/invoker.dart 288:9   Invoker.heartbeat.<fn>.<fn>
  dart:async/zone.dart 1398:13                      _rootRun
  dart:async/zone.dart 1300:19                      _CustomZone.run
  package:test_api/src/backend/invoker.dart 287:38  Invoker.heartbeat.<fn>
  dart:async-patch/timer_patch.dart 18:15           Timer._createTimer.<fn>
  dart:isolate-patch/timer_impl.dart 398:19         _Timer._runTimers
  dart:isolate-patch/timer_impl.dart 429:5          _Timer._handleMessage
  dart:isolate-patch/isolate_patch.dart 192:26      _RawReceivePort._handleMessage

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791626204200190129/+/u/run_test.dart_for_web_tests_shard_and_subshard_0/test_stdout
https://ci.chromium.org/p/flutter/builders/try/Linux%20Web%20Framework%20tests/22619

This started happening between 831db9410537 and 21cb5c1e7273

List of suspected commits:
https://dart.googlesource.com/sdk.git/+log/0097dcbada06..831db9410537

@sigmundch @nshahan @srujzs
@alexmarkov alexmarkov added P0 A serious issue requiring immediate resolution area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. labels Jan 18, 2023
@nshahan
Copy link
Contributor

nshahan commented Jan 18, 2023 •
edited
Loading

My change caused this error. I thought I already prepared for it in the flutter repo with this change flutter/flutter#118120.

I guess there is another location where the path to that file is hard coded. In this case the fix is very simple. We just need to update the path from dart-sdk/lib/dev_compiler/kernel/amd/require.js to dart-sdk/lib/dev_compiler/amd/require.js. I'll start looking at that test to see where it gets the path from.

If we roll back the change in the SDK we will need to handle the other packages that I have already updated to handle the new location. Golem will be particularly difficult because the build and tar operations there are especially brittle. The build_web_compilers package has already published a version to handle the new location as well.

@nshahan
Copy link
Contributor

nshahan commented Jan 18, 2023

Fix is out for review in the flutter repo: flutter/flutter#118722

@nshahan
Copy link
Contributor

nshahan commented Jan 18, 2023

My fix landed in flutter. AFAIK this should unblock rolling my Dart SDK changes into the engine.

This was the breaking change: https://dart-review.googlesource.com/c/sdk/+/275482

@nshahan nshahan self-assigned this Jan 19, 2023
@nshahan
Copy link
Contributor

nshahan commented Jan 19, 2023

Looks like my fix in the flutter repo has unblocked the roll. At this time my changes have rolled into flutter/engine and flutter/flutter.

@nshahan nshahan closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nshahan nshahan

Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. P0 A serious issue requiring immediate resolution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nshahan @alexmarkov