Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[CP] [deps] rev dartdoc #51061

Closed
Closed
@srawlins

Description

@srawlins

Commit(s) to merge

cabf333, partially

Target

beta

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/279320

Issue Description

Dartdoc had some regressions recently. One big one was dart-lang/dartdoc#3204, fixed in dart-lang/dartdoc#3271, released in dartdoc 6.1.5. In this bug, the up/down arrow keys navigate through the list of suggestions in the search box, but possibly out-of-order.

Also in dartdoc 6.1.5 is a fix for using the Enter key in the search field.

What is the fix

The fix was to use a flat structure for the suggestions, instead of a tree structure.

Why cherry-pick

dartdoc is used to build api.dart.dev, which would feature this bug for the docs generated for Dart 2.19.0.

Risk

low

Issue link(s)

dart-lang/dartdoc#3204

Extra Info

No response

Metadata

Metadata

Labels

area-toolsA meta category for issues that should be addressed by tooling (prefer more concrete areas).cherry-pick-approvedLabel for approved cherrypick requestcherry-pick-reviewIssue that need cherry pick triage to approvemerge-to-beta

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions