-
Notifications
You must be signed in to change notification settings - Fork 21
Remove DataFrame.take #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
But then how do you use the methods we have that return indices? ( |
Exactly, you don't Unless we accept some level of redesign, starting with #346 |
A DataFrame can have an arbitrary or can have an undefined order, but that doesn't mean it has to be. If it has a defined order or an arbitrary order, i.e. someone ran a The only situations where Let's continue discussion in #346 regarding Expressions, but I don't think |
How does a user know if a dataframe has input order defined or not? |
Some examples:
|
I think we could also generally specify that operations maintain the input order of the DataFrame unless otherwise noted. I believe we've made sure to add that into the docstring where appropriate, i.e. things like joins, groupbys, getting unique values, etc. are documented to not guarantee a specific output order. |
@kkraus14 #344 (comment)
If we only have one
DataFrame
class, and its order is undefined, thenDataFrame.take
isn't a well-defined operationAlternatives
Accept some level of re-design, even if it means extra work. But with the current design,
DataFrame.take
is undefined, so I suggest we remove it firstThe text was updated successfully, but these errors were encountered: