Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: use prettier/plugin-oxc (not for prettier-plugin-eslint though) #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 2, 2025
Merged

feat: use prettier/plugin-oxc (not for prettier-plugin-eslint though) #173

merged 4 commits into from
Nov 2, 2025

Conversation

@puehringer
Copy link
Contributor

@puehringer puehringer commented Nov 1, 2025 •
edited
Loading

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • Formats visyn_scripts with the same config as in the templates
  • Make prettier (run in standalone mode) faster by using the oxc plugin: https://www.solberg.is/prettier-is-fast
  • Unfortunately, it seems the eslint-plugin-prettier doesn't run prettier via oxc, so the eslint integration is still slow(er)
    • Therefore, we now enable prettier as separate call in the lint script, which is for now only enabled via a special to avoid any workflow migration on developer machines. We will revisit enabling this by default at a later point in time, because right now it would break with files that for example have eslint-disable, as prettier ignores those, causing errors.

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@puehringer puehringer added release: patch PR merge results in a new patch version type: feature New feature or request labels Nov 1, 2025
@puehringer puehringer force-pushed the mp/prettier_oxc branch 2 times, most recently from 934417d to d8cd373 Compare November 2, 2025 19:27
@puehringer puehringer marked this pull request as ready for review November 2, 2025 19:40
@puehringer puehringer requested a review from a team as a code owner November 2, 2025 19:40
@puehringer puehringer force-pushed the mp/prettier_oxc branch 4 times, most recently from ffc941b to 723abf8 Compare November 2, 2025 20:15
@puehringer puehringer changed the title feat: use prettier/plugin-oxc feat: use prettier/plugin-oxc (not for prettier-plugin-eslint though) Nov 2, 2025
@puehringer puehringer merged commit af1b140 into develop Nov 2, 2025
1 check passed
@puehringer puehringer deleted the mp/prettier_oxc branch November 2, 2025 20:23
@github-actions github-actions bot mentioned this pull request Nov 2, 2025
Merged
puehringer added a commit that referenced this pull request Nov 2, 2025
@puehringer
Release 15.1.3 (#174)
f0f92b8 
* chore: prepare next dev release

* feat: use prettier/plugin-oxc (not for prettier-plugin-eslint though) (#173)

* feat: use prettier/plugin-oxc

* More updates

* Lint all fiels

* Add format to lint

* Prepare release version 15.1.3

---------

Co-authored-by: datavisyn-bot <>
Co-authored-by: Michael Pühringer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

release: patch PR merge results in a new patch version type: feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@puehringer