Initialize the states array with calloc in _macosx.m

jkseppan · jkseppan · commit dbb80f4be2d8 · 2014-04-19T20:20:43.000+03:00
To silence a warning about garbage data from the clang
static analyzer. Also check the calloc return value.
diff --git a/src/_macosx.m b/src/_macosx.m
@@ -4489,7 +4489,12 @@ -(void)save_figure:(id)sender
     NSMenu* menu = [button menu];
     NSArray* items = [menu itemArray];
     unsigned int n = [items count];
-    int* states = malloc(n*sizeof(int));
+    int* states = calloc(n, sizeof(int));
+    if (!states)
+    {
+        PyErr_SetString(PyExc_RuntimeError, "calloc failed");
+        return NULL;
+    }
     int i;
     unsigned int m = 0;
     NSEnumerator* enumerator = [items objectEnumerator];
@@ -4504,7 +4509,6 @@ -(void)save_figure:(id)sender
             states[i] = 1;
             m++;
         }
-        else states[i] = 0;
     }
     int j = 0;
     PyObject* list = PyList_New(m);
