From c604302ad1d55b4221a12b05f94524e45079fe21 Mon Sep 17 00:00:00 2001 From: dlizewski Date: Mon, 14 Apr 2025 19:32:38 -0400 Subject: [PATCH] Fixed unreferenced function when using Long.fromValue with a bigInt --- index.js | 2 +- tests/index.js | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/index.js b/index.js index 9a0fe70..4983233 100644 --- a/index.js +++ b/index.js @@ -1562,7 +1562,7 @@ if (typeof BigInt === "function") { // Override Long.fromValue = function fromValueWithBigInt(value, unsigned) { - if (typeof value === "bigint") return fromBigInt(value, unsigned); + if (typeof value === "bigint") return Long.fromBigInt(value, unsigned); return fromValue(value, unsigned); }; diff --git a/tests/index.js b/tests/index.js index 56ba76c..3eab85e 100644 --- a/tests/index.js +++ b/tests/index.js @@ -267,6 +267,15 @@ var tests = [ assert.strictEqual(unsignedFromUnsigned.toBigInt(), values[i].unsigned); var signedFromUnsigned = Long.fromBigInt(values[i].unsigned); assert.strictEqual(signedFromUnsigned.toBigInt(), values[i].signed); + + var signedFromSigned = Long.fromValue(values[i].signed); + assert.strictEqual(signedFromSigned.toBigInt(), values[i].signed); + var unsignedFromSigned = Long.fromValue(values[i].signed, true); + assert.strictEqual(unsignedFromSigned.toBigInt(), values[i].unsigned); + var unsignedFromUnsigned = Long.fromValue(values[i].unsigned, true); + assert.strictEqual(unsignedFromUnsigned.toBigInt(), values[i].unsigned); + var signedFromUnsigned = Long.fromValue(values[i].unsigned); + assert.strictEqual(signedFromUnsigned.toBigInt(), values[i].signed); } },