Fixed #22772 -- Defer wizard temporary files deletion.

charettes · charettes · commit 26bdd1423b5f · 2014-06-06T23:41:15.000-04:00
diff --git a/formtools/tests/wizard/storage.py b/formtools/tests/wizard/storage.py
@@ -3,7 +3,7 @@
 import os
 import tempfile
 
-from django.http import HttpRequest
+from django.http import HttpRequest, HttpResponse
 from django.conf import settings
 from django.contrib.auth.models import User
 from django.core.files.storage import FileSystemStorage
@@ -107,4 +107,5 @@ def test_reset_deletes_tmp_files(self):
         self.assertTrue(storage.file_storage.exists(tmp_name))
 
         storage.reset()
+        storage.update_response(HttpResponse())
         self.assertFalse(storage.file_storage.exists(tmp_name))
diff --git a/formtools/wizard/storage/base.py b/formtools/wizard/storage/base.py
@@ -17,6 +17,7 @@ def __init__(self, prefix, request=None, file_storage=None):
         self.request = request
         self.file_storage = file_storage
         self._files = {}
+        self._tmp_files = []
 
     def init_data(self):
         self.data = {
@@ -27,11 +28,13 @@ def init_data(self):
         }
 
     def reset(self):
-        # Delete temporary files before breaking reference to them.
+        # Store unused temporary file names in order to delete them
+        # at the end of the response cycle through a callback attached in
+        # `update_response`.
         wizard_files = self.data[self.step_files_key]
         for step_files in six.itervalues(wizard_files):
             for step_file in six.itervalues(step_files):
-                self.file_storage.delete(step_file['tmp_name'])
+                self._tmp_files.append(step_file['tmp_name'])
         self.init_data()
 
     def _get_current_step(self):
@@ -118,6 +121,8 @@ def post_render_callback(response):
             for file in self._files.values():
                 if not file.closed:
                     file.close()
+            for tmp_file in self._tmp_files:
+                self.file_storage.delete(tmp_file)
 
         if hasattr(response, 'render'):
             response.add_post_render_callback(post_render_callback)
