Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Enable HTTP 30x redirections in curl requests (fix issue #589) #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2024
Merged

Enable HTTP 30x redirections in curl requests (fix issue #589) #592

merged 1 commit into from
Jan 13, 2024

Conversation

@sphakka
Copy link
Contributor

@sphakka sphakka commented Nov 7, 2023

Enable HTTP 30x redirections in curl requests -- fix issue #589:

  • curl: enable a configurable number of redirections (-redirects=<max>) to follow when making HTTP(S) requests.
  • docs: update Infomaniak example to prefer 'dyndns2' instead of obsolete protocol.

Test

F.i., with Infomaniak:

$ cat > /tmp/ddclient.conf <<EOF
pid=/tmp/ddclient.pid           
ssl=yes

protocol=dyndns2
use=web, web=infomaniak.com/ip.php/
server=infomaniak.com
login=$login
password=$password
# uncomment to test without CLI option -redirect
#redirect=2
$host      
EOF

Then:

$ ddclient -file=/tmp/ddclient.conf -daemon=0 -debug -verbose -noquiet -redirect=2

@sphakka
fix(curl, doc): enable HTTP 30x redirections in curl requests. Fixes …
235e702 
…Issue ddclient#589

- curl: enable a configurable number of redirections (-redirects=<max>) to
  follow when making HTTP(S) requests.
- docs: update Infomaniak example to prefer 'dyndns2' instead of obsolete
  protocol.

Signed-off-by: Marco Emilio "sphakka" Poleggi <[email protected]>
@LenardHess LenardHess mentioned this pull request Jan 13, 2024
Open
@LenardHess LenardHess merged commit dc84a74 into ddclient:master Jan 13, 2024
@LenardHess
Copy link
Contributor

LenardHess commented Jan 13, 2024

Merged 👍

For any future pull request, please separate different changes into separate commits or even separate pull requests.
I.e. in the PR we had changes to curl, changes to Infomaniak and random whitespace cleanup - all of which are not related. This makes it more tedious to traverse the history later.

@LenardHess LenardHess mentioned this pull request Jan 13, 2024
Open
3 tasks
@sphakka sphakka deleted the fix/issue-589 branch January 22, 2024 13:18
@chenrui333 chenrui333 mentioned this pull request Jan 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sphakka @LenardHess