Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@retep
Copy link
Contributor

@retep retep commented Jan 4, 2024

The mythicdyn module is modified so that it will update either or both V4 and/or V6 addresses depending upon which specific address parameters have been defined in the config file. The module monitors:
cmdv[46] fwv[46] usev[46] ipv[46] & ifv[46]
If required, both addresses will be updated in a single invocation.

The mythicdyn module is modified so that it will update either or both V4 and/or V6 addresses depending upon which specific address parameters have been defined in the config file.  The module monitors:
  cmdv[46] fwv[46] usev[46] ipv[46] & ifv[46]
If required, both addresses will be updated in a single invocation.
@LenardHess
Copy link
Contributor

Instead of reaching into the config and checking the cmd/if/ip/... stuff - please just check for the presence of wantipv4 and wantipv6 instead to determine which IP versions to update

@retep
Copy link
Contributor Author

retep commented Jan 7, 2024

Instead of reaching into the config and checking the cmd/if/ip/... stuff - please just check for the presence of wantipv4 and wantipv6 instead to determine which IP versions to update

Thank you for your suggestion. I had found wantipv[46] when reading the source code about 6 weeks ago and I thought I'd checked their relevance, then. However, i've checked again and I'm happy to include your suggestion in the rework, and it's made it a lot simpler (shorter). I've also taken the opportunity to set status-ipv[46] as appropriate for the cache. I've left status unchecked as I see there there's a "TODO" flag in the source suggesting it could/should be removed. Please let me know if you think this needs changing.

@retep retep closed this Jan 11, 2024
@retep retep deleted the retep-patch-1 branch January 11, 2024 16:36
@retep
Copy link
Contributor Author

retep commented Jan 13, 2024

Apologies for closing this PR and creating a new one. After much heading banging with Github, it was the easiest way I could find to get a PR back in line with the master.

@LenardHess
Copy link
Contributor

Ok - for future reference: To update a pull request, simply update the branch it was made on (i.e. retep:retep-patch-1 in this case). You can push new commits to it to add them to the PR or you can force-push the branch to fully update the commits of the PR.

@retep
Copy link
Contributor Author

retep commented Jan 14, 2024

Thanks for your patience and the guidance whiich is much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants