Add 'emailonly' client to send status emails without needing a DDNS host #654
Conversation
b316703 to
490fdd7
Compare
|
Thank you for the contribution! I rebased and added a handful of changes. If you approve, I'll squash and merge. |
TV4Fun
left a comment
There was a problem hiding this comment.
LGTM. Tested on my machine and it works properly. Thank you :). One very minor quibble, I like the idea of adding some indentation to host lines after the header, but with the SUCCESS: prefix before it, the result looks a little odd. See my screenshot.
|
By "a little odd" do you mean that there is too much indentation? Or that it would be better to omit the I set it to right align with a wide field so that multiple domains would align like this: |
|
Yes, I think it looks better without the |
|
@rhansen, I am not sure why, but there seems to be a bug introduced in this version—and the previous one—that was not in my original submission, that if the IP address has not changed since the last update, the update causes ddclient to report
I am investigating. |
This adds a protocol to email IP address changes without needing a dynamic DNS service. This is useful if you don't use a DDNS service but want to be notified when the IP of a machine changes.
|
There was a bug in my infinite duration commit. I force-pushed a fix; please try again. However, the error looks unrelated to this PR. Maybe something I recently changed on cat <<\EOF >./test.conf
protocol=emailonly \
usev4=ipv4 ipv4=192.0.2.1 \
usev6=ipv6 ipv6=2001:db8::1 \
host.example.com
EOF
make && ./ddclient --file=./test.conf --cache=./test.cache |
|
Yes, I have been running this branch now for 24 hours and have not had the issue again, so it looks like it has been fixed. Everything else is LGTM. |
|
Thanks for testing and thanks for the contribution! |
|
Not at all, thank you for your improvements! |
This adds a protocol to send status updates without needing a Dynamic
DNS host. This is useful if you don't have a DDNS host but want to be
updated when the IP of a machine changes. Because of how ddclient is
written, it requires setting a host name, but doesn't actually do
anything with it. Let me know if there's a better way to handle this.