he.net: Add support for Hurricane Electric provider #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f037edb to
be161ef
Compare
rhansen
requested changes
Jun 25, 2024
Member
rhansen
left a comment
There was a problem hiding this comment.
Thank you for the contribution @indrajitr! I rebased to the latest master and pushed some suggested changes. Please review and make any additional changes you want (force push is OK). If my suggested changes look good to you I'll squash (or you can) and merge.
rhansen
requested changes
Jun 25, 2024
c95e6d5 to
83ed577
Compare
Contributor
Author
|
Thanks @rhansen for picking this up! I got bit caught up on work front, but will test this out this weekend. |
rhansen
approved these changes
Jul 11, 2024
Member
rhansen
left a comment
There was a problem hiding this comment.
LGTM. Please let me know if it looks good to you. If so, I'll squash (or you can) and merge.
Contributor
Author
|
LGTM to me too. Just a minor whitespace nitpick and additional |
The implementation is based on the existing dyndns2 protocol with a few differences: - The IPv4 and IPv6 addresses must be updated in separate calls. This is different from most of the other providers where both IPv4 and IPv6 addresses can be updated in a single call. Thus the existing dyndns2 protocol implementation cannot be reused for dns.he.net. - Multiple hosts are not supported by the provider. See: https://dns.he.net/docs.html
This also makes the handling of deprecated services a bit more general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the Hurricane Electric provider.
The implementation is based on the existing dyndns2 protocol with a few differences:
See: https://dns.he.net/docs.html