-
Notifications
You must be signed in to change notification settings - Fork 369
Add new protocol inwx #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
906768c to
8114b61
Compare
rhansen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I pushed a handful of fixup commits. Would you please review them, test it again, and let me know if everything looks good? Feel free to make any changes.
Once I hear back I'll squash all the commits together and merge.
|
Thanks for reviewing! Your changes look good to me. The code works, but exits with this error message: I'm very sorry for not noticing this in the first place. Is this why you reverted PR #702? |
506dab4 to
8f7de8e
Compare
I reverted it because I was re-reading my changes and realized the bug. I did expect this PR to have problems—sorry for the hassle. The output you posted in #709 (comment) is unexpected. It looks like curl is printing two HTTP responses. Are you using an HTTP proxy? If so, ddclient has another (independent) bug that affects more than just your PR. |
Yes. Everything is fine, if i disable the proxy. I'll push the commit to apply the changes from PR 709. |
Adoption of protocol dyndns2 to support their custom URL: 'https://dyndns.inwx.com/nic/update?myip=<ipaddr>&myipv6=<ip6addr>'
625bd0a to
83ef1fa
Compare
|
Thanks for sticking with this. I opened #710 for the proxy issue. |
|
Hello @Starkstromkonsument When I execute ddclient, I get the following output: This seems good, but when I take a look at the INWX dashboard the only thing happening is an update of the A entry to my public ipv4 IP (the on I get from my ISP). But not to 192.168.0.19 or my Ipv6 address. Unfortunately I don't find any good documentation to find out if my config is right. Could you share an example config you used with INWX and ddclient that works? |
|
Please change Example: |
Works like a charm, thank you very much 👍 |
Adoption of protocol dyndns2 to support their custom URL:
https://dyndns.inwx.com/nic/update?myip=<ipaddr>&myipv6=<ip6addr>closes #96