Fix TypeScript strict null handling for header values.

ddunkin · ddunkin · commit a7a624f39f14 · 2018-01-25T14:26:17.000-07:00
diff --git a/example/ts/exampleApi.ts b/example/ts/exampleApi.ts
@@ -434,7 +434,7 @@ class ExampleApiHttpClient implements IExampleApi {
 				if (!value) {
 					return createResponseError(status, result.json) as IServiceResult<IGetWidgetResponse>;
 				}
-				let headerValue: string;
+				let headerValue: string | null | undefined;
 				headerValue = result.response.headers.get('eTag');
 				if (headerValue != null) {
 					value.eTag = headerValue;
diff --git a/src/Facility.CodeGen.JavaScript/JavaScriptGenerator.cs b/src/Facility.CodeGen.JavaScript/JavaScriptGenerator.cs
@@ -233,7 +233,7 @@ protected override CodeGenOutput GenerateOutputCore(ServiceInfo service)
 
 								if (httpMethodInfo.ResponseHeaderFields.Count != 0)
 								{
-									code.WriteLine("let headerValue" + IfTypeScript(": string") + ";");
+									code.WriteLine("let headerValue" + IfTypeScript(": string | null | undefined") + ";");
 									foreach (var httpHeaderField in httpMethodInfo.ResponseHeaderFields)
 									{
 										code.WriteLine($"headerValue = result.response.headers.get('{httpHeaderField.Name}');");

Original file line number	Diff line number	Diff line change
`@@ -434,7 +434,7 @@ class ExampleApiHttpClient implements IExampleApi {`
`434`	`434`	`if (!value) {`
`435`	`435`	`return createResponseError(status, result.json) as IServiceResult<IGetWidgetResponse>;`
`436`	`436`	`}`
`437`		`- let headerValue: string;`
	`437`	`+ let headerValue: string \| null \| undefined;`
`438`	`438`	`headerValue = result.response.headers.get('eTag');`
`439`	`439`	`if (headerValue != null) {`
`440`	`440`	`value.eTag = headerValue;`
Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,7 @@ protected override CodeGenOutput GenerateOutputCore(ServiceInfo service)`
`233`	`233`
`234`	`234`	`if (httpMethodInfo.ResponseHeaderFields.Count != 0)`
`235`	`235`	`{`
`236`		`- code.WriteLine("let headerValue" + IfTypeScript(": string") + ";");`
	`236`	`+ code.WriteLine("let headerValue" + IfTypeScript(": string \| null \| undefined") + ";");`
`237`	`237`	`foreach (var httpHeaderField in httpMethodInfo.ResponseHeaderFields)`
`238`	`238`	`{`
`239`	`239`	`code.WriteLine($"headerValue = result.response.headers.get('{httpHeaderField.Name}');");`