bar: set stroke-width to 0 when bar is blank

antoinerg · antoinerg · commit 709ee2fb8126 · 2019-09-11T13:48:59.000-04:00
diff --git a/src/components/drawing/index.js b/src/components/drawing/index.js
@@ -442,7 +442,7 @@ drawing.singlePointStyle = function(d, sel, trace, fns, gd) {
                 fill: 'none'
             });
     } else {
-        sel.style('stroke-width', lineWidth + 'px');
+        sel.style('stroke-width', (d.isBlank ? 0 : lineWidth) + 'px');
 
         var markerGradient = marker.gradient;
 
diff --git a/src/traces/bar/plot.js b/src/traces/bar/plot.js
@@ -142,7 +142,7 @@ function plot(gd, plotinfo, cdModule, traceLayer, opts, makeOnCompleteCallback)
             if(isBlank && !isHorizontal) y1 = y0;
 
             // in waterfall mode `between` we need to adjust bar end points to match the connector width
-            if(adjustPixel) {
+            if(adjustPixel && !isBlank) {
                 if(isHorizontal) {
                     x0 -= dirSign(x0, x1) * adjustPixel;
                     x1 += dirSign(x0, x1) * adjustPixel;
@@ -204,10 +204,6 @@ function plot(gd, plotinfo, cdModule, traceLayer, opts, makeOnCompleteCallback)
             var sel = transition(Lib.ensureSingle(bar, 'path'), opts, makeOnCompleteCallback);
             sel
                 .style('vector-effect', 'non-scaling-stroke')
-                .attr('display', function() {
-                    if(!isBlank) return null;
-                    if(isBlank && !hasTransition(opts)) return 'none';
-                })
                 .attr('d', 'M' + x0 + ',' + y0 + 'V' + y1 + 'H' + x1 + 'V' + y0 + 'Z')
                 .call(Drawing.setClipUrl, plotinfo.layerClipId, gd);
 
