Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DataSink FileDescriptor support #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mudar opened this issue May 16, 2020 · 2 comments · Fixed by #88
Closed

DataSink FileDescriptor support #87

mudar opened this issue May 16, 2020 · 2 comments · Fixed by #88

Comments

@mudar
Copy link
Collaborator

mudar commented May 16, 2020

Hi Mattia, I hope you're doing fine...

I'm creating this issue to link it to a PR: the DefaultDataSink constructor relies on the file path. I feel it would be useful to add a constructor that uses a FileDescriptor, especially for Android 10.

thanks,
mudar
@natario1
Copy link
Member

Thanks! :-)

@natario1
Copy link
Member

natario1 commented May 16, 2020 •
edited
Loading

Also if you want to release a 0.9.1 with this, feel free to do so, I have added you as collaborator. Refer to #66 as example to what is needed to prepare a release. Then just create a GitHub Release and CI should push to jcenter

@mudar mudar linked a pull request May 18, 2020 that will close this issue
DataSink, added fileDescriptor support #88
Merged
@mudar mudar closed this as completed May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DataSink, added fileDescriptor support mudar/Transcoder
2 participants
@mudar @natario1