[share] Do not tear down channel onDetachedFromActivity. (flutter#3942)

zhenqiu1101 · web-flow · commit 9b1f9ee38d33 · 2021-05-21T10:55:32.000-07:00
* Remove the tearDownChannel onDetachedFromActivity. Only set activity to null.

* update changelog

* increase version
diff --git a/packages/share/CHANGELOG.md b/packages/share/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 2.0.3
+
+* Do not tear down method channel onDetachedFromActivity.
+
 ## 2.0.2
 
 * Migrate maven repository from jcenter to mavenCentral.
diff --git a/packages/share/android/src/main/java/io/flutter/plugins/share/SharePlugin.java b/packages/share/android/src/main/java/io/flutter/plugins/share/SharePlugin.java
@@ -45,7 +45,7 @@ public void onAttachedToActivity(ActivityPluginBinding binding) {
 
   @Override
   public void onDetachedFromActivity() {
-    tearDownChannel();
+    share.setActivity(null);
   }
 
   @Override
@@ -64,9 +64,4 @@ private void setUpChannel(Context context, Activity activity, BinaryMessenger me
     handler = new MethodCallHandler(share);
     methodChannel.setMethodCallHandler(handler);
   }
-
-  private void tearDownChannel() {
-    share.setActivity(null);
-    methodChannel.setMethodCallHandler(null);
-  }
 }
diff --git a/packages/share/pubspec.yaml b/packages/share/pubspec.yaml
@@ -2,7 +2,7 @@ name: share
 description: Flutter plugin for sharing content via the platform share UI, using
   the ACTION_SEND intent on Android and UIActivityViewController on iOS.
 homepage: https://github.com/flutter/plugins/tree/master/packages/share
-version: 2.0.2
+version: 2.0.3
 
 flutter:
   plugin:

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public void onAttachedToActivity(ActivityPluginBinding binding) {`
`45`	`45`
`46`	`46`	`@Override`
`47`	`47`	`public void onDetachedFromActivity() {`
`48`		`- tearDownChannel();`
	`48`	`+ share.setActivity(null);`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`@Override`
`@@ -64,9 +64,4 @@ private void setUpChannel(Context context, Activity activity, BinaryMessenger me`
`64`	`64`	`handler = new MethodCallHandler(share);`
`65`	`65`	`methodChannel.setMethodCallHandler(handler);`
`66`	`66`	`}`
`67`		`-`
`68`		`- private void tearDownChannel() {`
`69`		`- share.setActivity(null);`
`70`		`- methodChannel.setMethodCallHandler(null);`
`71`		`- }`
`72`	`67`	`}`