0.90-fixes: Fixed minor security hole in compile-messages.py. See trunk patch in [3592]

ubernostrum · ubernostrum · commit 6eefa521be3c · 2006-08-16T06:29:22.000Z
git-svn-id: http://code.djangoproject.com/svn/django/branches/0.90-bugfixes@3594 bcc190cf-cafb-0310-a4f2-bffc1f526a37
diff --git a/django/bin/compile-messages.py b/django/bin/compile-messages.py
@@ -19,6 +19,13 @@
         if file.endswith('.po'):
             sys.stderr.write('processing file %s in %s\n' % (file, dirpath))
             pf = os.path.splitext(os.path.join(dirpath, file))[0]
-            cmd = 'msgfmt -o %s.mo %s.po' % (pf, pf)
+            # Store the names of the .mo and .po files in an environment
+            # variable, rather than doing a string replacement into the
+            # command, so that we can take advantage of shell quoting, to
+            # quote any malicious characters/escaping.
+            # See http://cyberelk.net/tim/articles/cmdline/ar01s02.html
+            os.environ['djangocompilemo'] = pf + '.mo'
+            os.environ['djangocompilepo'] = pf + '.po'
+            cmd = 'msgfmt -o "$djangocompilemo" "$djangocompilepo"'
             os.system(cmd)
 
