fix: copy lang management command - include PageUrl (#7548)

vasekch · fsbraun · web-flow · commit 446219c5aec4 · 2025-09-10T09:25:32.000+02:00
* fix: copy lang management command

Include copy of related PageUrl models

* Update cms/management/commands/subcommands/copy.py

* Apply suggestions from code review

* Update cms/management/commands/subcommands/copy.py

* Add test to check page urls are created

* Add import for sys module in test_management.py

---------

Co-authored-by: Fabian Braun &lt;fsbraun@gmx.de&gt;
diff --git a/cms/management/commands/subcommands/copy.py b/cms/management/commands/subcommands/copy.py
@@ -6,8 +6,9 @@
 
 from cms.api import copy_plugins_to_language
 from cms.management.commands.subcommands.base import SubcommandsCommand
-from cms.models import EmptyPageContent, Page, PageContent
+from cms.models import EmptyPageContent, Page, PageContent, PageUrl
 from cms.utils import get_language_list
+from cms.utils.page import get_available_slug
 from cms.utils.plugins import copy_plugins_to_placeholder
 
 User = get_user_model()
@@ -71,7 +72,8 @@ def handle(self, *args, **options):
         except AssertionError:
             raise CommandError('Both languages have to be present in settings.LANGUAGES and settings.CMS_LANGUAGES')
 
-        for page in Page.objects.on_site(site):
+        # obey node path (tree order) to make sure parent records are created before children (for slug generation)
+        for page in Page.objects.on_site(site).order_by('path'):
             # copy title
             if from_lang in page.get_languages():
 
@@ -89,6 +91,29 @@ def handle(self, *args, **options):
                     new_title["page"] = page
                     PageContent.objects.with_user(user).create(**new_title)
 
+                    if to_lang not in page.get_languages():
+                        page.update_languages(page.get_languages() + [to_lang])
+
+                    # copy PageUrls - inspired from pagemodels.Page.copy() - possibly refactorable
+                    page_url = page.urls.get(language=from_lang)
+                    parent_page = page.parent
+
+                    new_url = model_to_dict(page_url)
+                    new_url.pop("id", None)  # No PK
+                    new_url["page"] = page
+                    new_url["language"] = to_lang
+
+                    if parent_page:
+                        base = parent_page.get_path(to_lang)
+                        path = '%s/%s' % (base, page_url.slug) if base else page_url.slug
+                    else:
+                        base = ''
+                        path = page_url.slug
+
+                    new_url["slug"] = get_available_slug(site, path, to_lang)
+                    new_url["path"] = '%s/%s' % (base, new_url["slug"]) if base else new_url["slug"]
+                    PageUrl.objects.with_user(user).create(**new_url)
+
                 if copy_content:
                     # copy plugins using API
                     if verbose:
diff --git a/cms/tests/test_management.py b/cms/tests/test_management.py
@@ -1,8 +1,5 @@
 import os
-import shutil
 import sys
-import tempfile
-import uuid
 from io import StringIO
 
 from django.conf import settings
@@ -15,7 +12,7 @@
 
 from cms.api import add_plugin, create_page, create_page_content
 from cms.management.commands.subcommands.list import plugin_report
-from cms.models import Page
+from cms.models import Page, PageUrl
 from cms.models.placeholdermodel import Placeholder
 from cms.models.pluginmodel import CMSPlugin
 from cms.test_utils.fixtures.navextenders import NavextendersFixture
@@ -346,6 +343,7 @@ def test_copy_langs(self):
         """
         site = 1
         number_start_plugins = CMSPlugin.objects.all().count()
+        number_urls = PageUrl.objects.filter(language='en').count()
 
         out = StringIO()
         management.call_command(
@@ -382,6 +380,8 @@ def test_copy_langs(self):
         self.assertEqual(stack_text_en.plugin_type, stack_text_de.plugin_type)
         self.assertEqual(stack_text_en.body, stack_text_de.body)
 
+        self.assertEqual(PageUrl.objects.filter(language='de').count(), number_urls)
+
     def test_copy_langs_no_content(self):
         """
         Various checks here:
