Fix error handling of mysql_real_connect (PyMySQL#317)

methane · web-flow · commit ea80e8f07a80 · 2018-12-17T19:27:54.000+09:00
Fixes PyMySQL#316
diff --git a/MySQLdb/_mysql.c b/MySQLdb/_mysql.c
@@ -446,6 +446,7 @@ _mysql_ConnectionObject_Initialize(
 
     Py_BEGIN_ALLOW_THREADS ;
     conn = mysql_init(&(self->connection));
+    self->open = 1;
     if (connect_timeout) {
         unsigned int timeout = connect_timeout;
         mysql_options(&(self->connection), MYSQL_OPT_CONNECT_TIMEOUT,
@@ -496,6 +497,7 @@ _mysql_ConnectionObject_Initialize(
 
     if (!conn) {
         _mysql_Exception(self);
+        self->open = 0;
         return -1;
     }
 
@@ -515,7 +517,6 @@ _mysql_ConnectionObject_Initialize(
       be done here. tp_dealloc still needs to call PyObject_GC_UnTrack(),
       however.
     */
-    self->open = 1;
     return 0;
 }
 
