Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 9c7517e

Browse files
glemaitredmohns
authored andcommitted
[MRG] DOC change rebase to merge policy (scikit-learn#8753)
* DOC change rebase to merge policy * FIX remove no-ff flag
1 parent 0e512af commit 9c7517e

1 file changed

Lines changed: 16 additions & 6 deletions

File tree

doc/developers/contributing.rst

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -155,12 +155,22 @@ If any of the above seems like magic to you, then look up the `Git documentation
155155
<http://docs.scipy.org/doc/numpy/dev/gitwash/development_workflow.html>`_ on the
156156
web.
157157

158-
In particular, if some conflicts arise between your branch and the master
159-
branch, you will need to `rebase your branch on master
160-
<http://docs.scipy.org/doc/numpy/dev/gitwash/development_workflow.html#rebasing-on-master>`_.
161-
Please avoid merging master branch into yours. If you did it anyway, you can fix
162-
it following `this example
163-
<https://github.com/scikit-learn/scikit-learn/pull/7111#issuecomment-249175383>`_.
158+
If some conflicts arise between your branch and the ``master`` branch, you need
159+
to merge ``master``. The command will be::
160+
161+
$ git merge master
162+
163+
with ``master`` being synchronized with the ``upstream``.
164+
165+
Subsequently, you need to solve the conflicts. You can refer to the `Git
166+
documentation related to resolving merge conflict using the command line
167+
<https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/>`_.
168+
169+
.. note::
170+
171+
In the past, the policy to resolve conflicts was to rebase your branch on
172+
``master``. GitHub interface deals with merging ``master`` better than in
173+
the past.
164174

165175

166176
Contributing pull requests

0 commit comments

Comments
 (0)