We need to relabel newly created container volumes#23024
Merged
Conversation
Contributor
Author
|
@shishir-a412ed Could you try this out with docker-lvm-plugin. Works for me. :^) |
Contributor
|
@dwalsh works fine for me. I did this:
|
Contributor
|
@rhatdan i believe the test failures are real and related to this change. It is the same tests on each of the checks that are failing. |
Contributor
|
ping @rhatdan |
Contributor
Author
|
I had forgotten about this one, Updated to upstream and will take a fresh look at this. |
This will add a label to any volume that is shared into a container. Signed-off-by: Dan Walsh <[email protected]>
Member
|
Since the dir is part of the container's rootfs, why wouldn't this already be labeled? |
Contributor
|
LGTM @cpuguy83 labels are applied per mountpoint |
Member
|
LGTM |
Merged
runcom
pushed a commit
to projectatomic/docker
that referenced
this pull request
Dec 4, 2016
Upstream reference: moby#23024 BZ#1401260 This will add a label to any volume that is shared into a container. Signed-off-by: Dan Walsh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will add a label to any volume that is shared into a container.
Signed-off-by: Dan Walsh [email protected]