I should have asked when reviewing https://github.com/doctrine/orm/pull/8870/files#diff-3e426fe47b58d2d4b970b1b7a0cbf5999af950e4f84e48dce4bee5061b57ed31R657 (cc @derrabus ), but what good is a getName() method when you can use instanceof? Isn't it more fragile?
In the past I remember Symfony deprecating form names, and recommending avoidance of services IDs that are not FQCN, and IMO this has makes things more clear. Should we get rid of AbstractPlatform::getName() as well?
I should have asked when reviewing https://github.com/doctrine/orm/pull/8870/files#diff-3e426fe47b58d2d4b970b1b7a0cbf5999af950e4f84e48dce4bee5061b57ed31R657 (cc @derrabus ), but what good is a
getName()method when you can useinstanceof? Isn't it more fragile?In the past I remember Symfony deprecating form names, and recommending avoidance of services IDs that are not FQCN, and IMO this has makes things more clear. Should we get rid of
AbstractPlatform::getName()as well?