Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 2faa11c

Browse files
greg0iregreg0ire
committed
Resort on Query::HINT_FORCE_PARTIAL_LOAD less
A lot of our tests mention it, but I do not think it is important to the test. Maybe it was a way to have more efficient tests? Most times, removing the hint does not affect the test outcome.
1 parent 4e13890 commit 2faa11c

4 files changed

Lines changed: 46 additions & 54 deletions

File tree

‎tests/Doctrine/Tests/ORM/Functional/ManyToManyBidirectionalAssociationTest.php‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,7 @@ private function createLoadingFixture(): void
109109
/** @psalm-return list<ECommerceProduct> */
110110
protected function findProducts(): array
111111
{
112-
$query = $this->_em->createQuery('SELECT p, c FROM Doctrine\Tests\Models\ECommerce\ECommerceProduct p LEFT JOIN p.categories c ORDER BY p.id, c.id');
113-
//$query->setHint(Query::HINT_FORCE_PARTIAL_LOAD, true);
112+
$query = $this->_em->createQuery('SELECT p, c FROM Doctrine\Tests\Models\ECommerce\ECommerceProduct p LEFT JOIN p.categories c ORDER BY p.id, c.id');
114113
$result = $query->getResult();
115114
self::assertCount(2, $result);
116115
$cats1 = $result[0]->getCategories();
@@ -126,8 +125,7 @@ protected function findProducts(): array
126125
/** @psalm-return list<ECommerceCategory> */
127126
protected function findCategories(): array
128127
{
129-
$query = $this->_em->createQuery('SELECT c, p FROM Doctrine\Tests\Models\ECommerce\ECommerceCategory c LEFT JOIN c.products p ORDER BY c.id, p.id');
130-
//$query->setHint(Query::HINT_FORCE_PARTIAL_LOAD, true);
128+
$query = $this->_em->createQuery('SELECT c, p FROM Doctrine\Tests\Models\ECommerce\ECommerceCategory c LEFT JOIN c.products p ORDER BY c.id, p.id');
131129
$result = $query->getResult();
132130
self::assertCount(2, $result);
133131
self::assertInstanceOf(ECommerceCategory::class, $result[0]);

‎tests/Doctrine/Tests/ORM/Functional/Ticket/GH6362Test.php‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
use Doctrine\ORM\Mapping\InheritanceType;
1616
use Doctrine\ORM\Mapping\ManyToOne;
1717
use Doctrine\ORM\Mapping\OneToMany;
18-
use Doctrine\ORM\Query;
1918
use Doctrine\ORM\Query\ResultSetMapping;
2019
use Doctrine\Tests\Mocks\ArrayResultFactory;
2120
use Doctrine\Tests\OrmFunctionalTestCase;
@@ -79,7 +78,7 @@ public function testInheritanceJoinAlias(): void
7978

8079
$stmt = ArrayResultFactory::createFromArray($resultSet);
8180
$hydrator = new ObjectHydrator($this->_em);
82-
$result = $hydrator->hydrateAll($stmt, $rsm, [Query::HINT_FORCE_PARTIAL_LOAD => true]);
81+
$result = $hydrator->hydrateAll($stmt, $rsm);
8382

8483
self::assertInstanceOf(GH6362Start::class, $result[0]['base']);
8584
self::assertInstanceOf(GH6362Child::class, $result[1][0]);

0 commit comments

Comments
 (0)