#1130 DDC-3300 - optimizing performance (looping over existing classes first): throwing exceptions if the class is not found in the discriminator map

Ocramius · Ocramius · commit a36bea295103 · 2015-01-22T09:44:39.000+01:00
diff --git a/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php b/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php
@@ -308,21 +308,37 @@ protected function newClassMetadataInstance($className)
      *
      * @param ClassMetadata $metadata
      *
+     * @return void
+     *
      * @throws MappingException
      */
     private function populateDiscriminatorValue(ClassMetadata $metadata)
     {
-        if (! $metadata->discriminatorValue && $metadata->discriminatorMap) {
-            foreach ($metadata->discriminatorMap as $discriminatorValue => $discriminatorClass) {
-                if ($metadata->name === $this->getMetadataFor($discriminatorClass)->getName()) {
-                    $metadata->discriminatorValue = $discriminatorValue;
+        if ($metadata->discriminatorValue
+            || ! $metadata->discriminatorMap
+            || $metadata->isMappedSuperclass
+            || $metadata->reflClass->isAbstract()
+        ) {
+            return;
+        }
 
-                    break;
-                }
+        foreach ($metadata->discriminatorMap as $discriminatorValue => $discriminatorClass) {
+            if ($discriminatorClass === $metadata->name) {
+                $metadata->discriminatorValue = $discriminatorValue;
+
+                return;
             }
+        }
+
+        foreach ($metadata->discriminatorMap as $discriminatorValue => $discriminatorClass) {
+            if ($metadata->name === $this->getMetadataFor($discriminatorClass)->getName()) {
+                $metadata->discriminatorValue = $discriminatorValue;
 
-            //throw MappingException::mappedClassNotPartOfDiscriminatorMap($metadata->name, $metadata->rootEntityName);
+                return;
+            }
         }
+
+        throw MappingException::mappedClassNotPartOfDiscriminatorMap($metadata->name, $metadata->rootEntityName);
     }
 
     /**
