XmlDriver: Avoid PHP bug #62577 by avoiding simplexml_load_file.

Aljosha Papsch · Aljosha Papsch · commit eb762dea2301 · 2017-08-18T14:23:43.000+02:00
Doctrine is affected by PHP bug #62577. simplexml_load_file is not
able to load files if libxml_disable_entity_loader(true) has been
called. simplexml_load_file fails with the message:

I/O warning : failed to load external entity "/my/mappings/my_entity.dcm.xml"
in /path-to/lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php on line 711

This error occurs even if there are no external entities in the XML file.

Waiting for the PHP bug to be resolved is infeasible, because it is
unresolved since years. Therefore Doctrine needs to circumvent the bug
by replacing simplexml_load_file with simplexml_load_string while getting
the file contents itself. simplexml_load_string is not affected by the
PHP bug.
diff --git a/lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php b/lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php
@@ -838,7 +838,7 @@ private function _getCascadeMappings(SimpleXMLElement $cascadeElement)
     protected function loadMappingFile($file)
     {
         $result = [];
-        $xmlElement = simplexml_load_file($file);
+        $xmlElement = simplexml_load_string(file_get_contents($file));
 
         if (isset($xmlElement->entity)) {
             foreach ($xmlElement->entity as $entityElement) {

Original file line number	Diff line number	Diff line change
`@@ -838,7 +838,7 @@ private function _getCascadeMappings(SimpleXMLElement $cascadeElement)`
`838`	`838`	`protected function loadMappingFile($file)`
`839`	`839`	`{`
`840`	`840`	`$result = [];`
`841`		`- $xmlElement = simplexml_load_file($file);`
	`841`	`+ $xmlElement = simplexml_load_string(file_get_contents($file));`
`842`	`842`
`843`	`843`	`if (isset($xmlElement->entity)) {`
`844`	`844`	`foreach ($xmlElement->entity as $entityElement) {`