[WIP] Bump the requirements to PHP 8.1 #2935
Conversation
d7efb79 to
58661be
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2935 +/- ##
==========================================
- Coverage 78.51% 78.34% -0.17%
==========================================
Files 168 167 -1
Lines 8782 8678 -104
==========================================
- Hits 6895 6799 -96
+ Misses 1887 1879 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "behat/transliterator": "^1.3", | ||
| "doctrine/collections": "^1.6.5 || ^2.0", |
There was a problem hiding this comment.
Just for reference, all the changes to the minimum versions are either to get to a functional set of dependencies on PHP 8.1 (the transliterator package has errors on older versions, doctrine/common doesn't support some PHP 8.1 reflection changes until 3.1) or change to match the versions currently being installed on the prefer-lowest build. Considering how old some of these releases are it shouldn't be a big deal, I hope.
According to the Packagist stats there was a large fall off PHP 7 users after the 3.14 release, which is when the requirement was bumped up to PHP 7.4. Since then, PHP 7.4 and 8.0 combined have had pretty small numbers on newer release branches and is generally now under 5% of the install base. So this PR bumps the requirement to PHP 8.1.
The overwhelming majority of the code changes are from adjusting the Rector and PHP-CS-Fixer configs to apply PHP 8.1 rulesets, with a second pass specifically on the tests to add type declarations there, then only minor corrections or tweaks by my own review along the way.