Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix null layer not producing nullptr in the XR extension loading system #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Perksey opened this issue Jun 2, 2021 · 0 comments · Fixed by #505
Closed

Fix null layer not producing nullptr in the XR extension loading system #501

Perksey opened this issue Jun 2, 2021 · 0 comments · Fixed by #505
Assignees
@Perksey
Labels
area-Vulkan bug Something isn't working
Milestone
2.X

Comments

@Perksey
Copy link
Member

Perksey commented Jun 2, 2021

Using null for the layer parameter of IsInstanceExtensionPresent or TryGetInstanceExtension doesn't send nullptr as expected to native. Instead, it sends a pointer to an empty string.

This should be fixed, ideally with appropriate nullability annotations applied.
@Perksey Perksey added the bug Something isn't working label Jun 2, 2021
@Perksey Perksey added this to the 2.X milestone Jun 2, 2021
@Perksey Perksey self-assigned this Jun 2, 2021
@Perksey Perksey mentioned this issue Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Perksey Perksey

Labels
area-Vulkan bug Something isn't working
Projects
None yet
Milestone
2.X
Development

Successfully merging a pull request may close this issue.

This is the June 2021 Update (v2.5.0) with production-ready OpenXR dotnet/Silk.NET
1 participant
@Perksey