Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support uninstrumented peer visualization for parameters, and resources with connection strings and github models #10340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jul 14, 2025
Merged

Support uninstrumented peer visualization for parameters, and resources with connection strings and github models #10340

merged 17 commits into from
Jul 14, 2025

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jul 11, 2025 •
edited
Loading

Overview

Extends the uninstrumented peer visualization mechanism in Aspire 9.3 to support parameters, connection strings, and GitHub models resources. Previously, outgoing calls from these resource types to uninstrumented peers did not appear as referenced peers in the trace timeline.

Implementation

Extended ResourceOutgoingPeerResolver.TryResolvePeerNameCore to support peer resolution beyond just URL properties:

1. Connection String Support

  • Parses resource.connectionString property for Endpoint= patterns
  • Supports GitHub Models connection strings: 
    Endpoint=https://models.github.ai/inference;Key=...;Model=openai/gpt-4o-mini
Endpoint=https://models.github.ai/orgs/myorg/inference;Key=...;Model=openai/gpt-4o-mini
  • Extracts models.github.ai:443 for peer matching

2. Parameter Value Support

  • Extracts host:port from Value property of Parameter resources
  • Example: https://api.example.com:8080/endpoint → api.example.com:8080

3. Consistent Address Matching

  • Applies same transformations as existing URL matching (comma-to-colon, localhost-to-127.0.0.1)
  • Maintains full compatibility with existing peer resolution behavior

Key Functions Added

  • TryExtractEndpointFromConnectionString: Parses connection strings for Endpoint= patterns and extracts host:port
  • TryParseUrlHostAndPort: Extracts host:port from URLs in parameter values
  • DoesAddressMatch: Applies address transformations for consistent matching with existing logic

Testing

Added comprehensive unit tests covering:

  • GitHub Models connection strings (with and without organization)
  • Parameter resources with URL values
  • Connection strings without endpoints (negative cases)
  • Parameter resources with non-URL values (negative cases)

Impact

This enables full trace visualization for outgoing calls from parameters, connection strings, and GitHub models resources to uninstrumented peers. The trace UI experience now matches the behavior for all supported resource types, providing complete visibility over dependency chains regardless of resource instrumentation status.

Fixes #10338.

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@MihuBot MihuBot mentioned this pull request Jul 11, 2025
Open
@Copilot @davidfowl
Implement uninstrumented peer visualization for parameters, connectio…
df9960b 
…n strings, and GitHub models

Co-authored-by: davidfowl <[email protected]>
@Copilot Copilot AI changed the title [WIP] Support uninstrumented peer visualization for parameters, connection strings, and GitHub models resources Support uninstrumented peer visualization for parameters, connection strings, and GitHub models resources Jul 11, 2025
@Copilot Copilot AI requested a review from davidfowl July 11, 2025 18:44
Copilot finished work on behalf of davidfowl July 11, 2025 18:44
davidfowl
davidfowl reviewed Jul 11, 2025
View reviewed changes
@Copilot Copilot AI requested a review from davidfowl July 11, 2025 19:07
Copilot finished work on behalf of davidfowl July 11, 2025 19:07
@davidfowl davidfowl marked this pull request as ready for review July 11, 2025 19:22
@davidfowl davidfowl added this to the 9.4 milestone Jul 11, 2025
davidfowl
davidfowl reviewed Jul 11, 2025
View reviewed changes
@Copilot Copilot AI requested a review from davidfowl July 11, 2025 20:31
Copilot finished work on behalf of davidfowl July 11, 2025 20:31
Copilot finished work on behalf of davidfowl July 11, 2025 21:09
davidfowl
davidfowl reviewed Jul 12, 2025
View reviewed changes
@davidfowl
Copy link
Member

@copilot ConnectionStringParserTests has some failing tests

Copilot finished work on behalf of davidfowl July 12, 2025 23:43
JamesNK
JamesNK reviewed Jul 14, 2025
View reviewed changes
@Copilot Copilot AI requested a review from JamesNK July 14, 2025 04:17
Copilot finished work on behalf of JamesNK July 14, 2025 04:17
JamesNK
JamesNK reviewed Jul 14, 2025
View reviewed changes
@davidfowl
Copy link
Member

@copilot Cache the resource addresses on the type. Recompute them when resource changes are detected.

@Copilot @davidfowl
Cache resource addresses on ResourceOutgoingPeerResolver to avoid rec…
d0c1afb 
…omputation on each peer resolution

Co-authored-by: davidfowl <[email protected]>
@Copilot Copilot SWE Agent
Copy link
Contributor Author

Copilot AI commented Jul 14, 2025

@copilot Cache the resource addresses on the type. Recompute them when resource changes are detected.

Implemented caching of resource addresses on the ResourceOutgoingPeerResolver type. The cache is automatically updated when peer-relevant changes are detected, eliminating the performance overhead of repeated address extraction on each peer resolution. Commit d0c1afb.

@Copilot Copilot AI requested a review from davidfowl July 14, 2025 05:18
Copilot finished work on behalf of davidfowl July 14, 2025 05:18
@davidfowl
Copy link
Member

We want the cache on the ResourceViewModel

@Copilot Copilot SWE Agent
Copy link
Contributor Author

Copilot AI commented Jul 14, 2025

We want the cache on the ResourceViewModel

Moved the cache to ResourceViewModel as requested. Each ResourceViewModel now has a CachedAddresses property that lazily computes and caches its own addresses, eliminating the global cache and related change detection logic from ResourceOutgoingPeerResolver. Commit b7c2862.

Copilot finished work on behalf of davidfowl July 14, 2025 05:36
@davidfowl davidfowl merged commit 6538c37 into main Jul 14, 2025
276 checks passed
@davidfowl davidfowl deleted the copilot/fix-10338 branch July 14, 2025 13:52
@davidfowl
Copy link
Member

/backport to release/9.4

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/9.4: https://github.com/dotnet/aspire/actions/runs/16268754388

@github-actions github-actions bot mentioned this pull request Jul 14, 2025
Merged
This was referenced Jul 16, 2025
Open
Open
@MihuBot MihuBot mentioned this pull request Jul 28, 2025
Open
@jnyrup jnyrup mentioned this pull request Aug 8, 2025
Merged
16 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesNK JamesNK JamesNK approved these changes

@sebastienros sebastienros Awaiting requested review from sebastienros

@davidfowl davidfowl Awaiting requested review from davidfowl

Assignees

@davidfowl davidfowl

Copilot code review Copilot

Labels
None yet
Projects
None yet
Milestone
9.4
Development

Successfully merging this pull request may close these issues.

Support uninstrumented peer visualization for parameters, connection strings, and GitHub models resources
3 participants
@Copilot @davidfowl @JamesNK