Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Secret arguments are displayed in tooltip #7634

@sebastienros

Description

@sebastienros

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

When adding arguments to a resource as a secret it is correctly redacted on the dashboard resources page. However the tooltip shows the secret without any user action. I would have expected it to not show up.

Image

Going into the details popup it's also displayed without user interaction. I don't think secrets should show unless an explicit interaction like "show secrets" or click a special "eye" icon is done. Same as what is done for ENVs in the properties.

Image

Example: doing a demo with a connection string and unintentionally showing secrets.

Expected Behavior

Execute a special gesture to reveal secrets on screen.

Steps To Reproduce

var connectionString = builder.AddParameter("connectionString", "my-secret", secret: true);
var exe = builder.AddExecutable("myexe", "-arg1", "--connectionstring", connectionString);

Exceptions (if any)

No response

.NET Version info

No response

Anything else?

No response

Metadata

Metadata

Assignees

Type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions