From 092efd64b3a9476a7759c38af98fcf0258bc62b7 Mon Sep 17 00:00:00 2001 From: Mackinnon Buck Date: Thu, 29 Aug 2024 14:30:44 -0700 Subject: [PATCH 1/2] Scroll button into view before click --- src/Components/test/E2ETest/Tests/CircuitTests.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Components/test/E2ETest/Tests/CircuitTests.cs b/src/Components/test/E2ETest/Tests/CircuitTests.cs index f4b4999c8b25..7a0cd6bb18bd 100644 --- a/src/Components/test/E2ETest/Tests/CircuitTests.cs +++ b/src/Components/test/E2ETest/Tests/CircuitTests.cs @@ -7,6 +7,7 @@ using Microsoft.AspNetCore.E2ETesting; using Microsoft.AspNetCore.InternalTesting; using OpenQA.Selenium; +using OpenQA.Selenium.Support.Extensions; using TestServer; using Xunit.Abstractions; @@ -48,6 +49,7 @@ public void ComponentLifecycleMethodThrowsExceptionTerminatesTheCircuit(string i Browser.Exists(By.CssSelector("#blazor-error-ui[style='display: block;']")); // Clicking the button again will trigger a server disconnect + Browser.ExecuteJavaScript("arguments[0].scrollIntoView();", targetButton); targetButton.Click(); AssertLogContains("Connection disconnected."); @@ -70,6 +72,7 @@ public void ComponentDisposeMethodThrowsExceptionTerminatesTheCircuit() Browser.Exists(By.CssSelector("#blazor-error-ui[style='display: block;']")); // Clicking it again causes the circuit to disconnect + Browser.ExecuteJavaScript("arguments[0].scrollIntoView();", targetButton); targetButton.Click(); AssertLogContains("Connection disconnected."); } From 5ab409fcc338324560e07ecf9c4139216b6c8fc0 Mon Sep 17 00:00:00 2001 From: Mackinnon Buck Date: Tue, 3 Sep 2024 11:16:51 -0700 Subject: [PATCH 2/2] Set `alignToTop` argument to `true` --- src/Components/test/E2ETest/Tests/CircuitTests.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Components/test/E2ETest/Tests/CircuitTests.cs b/src/Components/test/E2ETest/Tests/CircuitTests.cs index 7a0cd6bb18bd..71ba80f83086 100644 --- a/src/Components/test/E2ETest/Tests/CircuitTests.cs +++ b/src/Components/test/E2ETest/Tests/CircuitTests.cs @@ -49,7 +49,7 @@ public void ComponentLifecycleMethodThrowsExceptionTerminatesTheCircuit(string i Browser.Exists(By.CssSelector("#blazor-error-ui[style='display: block;']")); // Clicking the button again will trigger a server disconnect - Browser.ExecuteJavaScript("arguments[0].scrollIntoView();", targetButton); + Browser.ExecuteJavaScript("arguments[0].scrollIntoView(true);", targetButton); targetButton.Click(); AssertLogContains("Connection disconnected."); @@ -72,7 +72,7 @@ public void ComponentDisposeMethodThrowsExceptionTerminatesTheCircuit() Browser.Exists(By.CssSelector("#blazor-error-ui[style='display: block;']")); // Clicking it again causes the circuit to disconnect - Browser.ExecuteJavaScript("arguments[0].scrollIntoView();", targetButton); + Browser.ExecuteJavaScript("arguments[0].scrollIntoView(true);", targetButton); targetButton.Click(); AssertLogContains("Connection disconnected."); }