-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Fixed devtools url used for debug with chrome and edge #61813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your PR, @@Dona278. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
I'm comfortable on approving the PR with the suggestions that @ilonatommy did, and also @ilonatommy if you have time can you give a double test? Maybe with an old and a new chrome/edge version? |
@thaystg I'm not an expert in this area, so if you think the change is good enough, I'm happy with it. Do you know if this affects debugging under VS or is this just for debugging directly from the dev tools? |
If can help: with that change, VS debug still works, and because all stuffs are under "display browser debug information" context and are based only on what browser returns back if lanched with specific command, I think that VS debugging isn't affected. |
@thaystg after applied suggestions I saw that the code can be changed to a simple "if it is already correct use as is, othewise keep its query string and append to the default browser devtools path". I also added comment which explain that with example of new (both chrome and edge) and old version. @javiercn now I think it is more clear the reason why. |
This PR ensure the correct creation of the devtools url with proxy to use for debug with chrome and edge browser which recently changed how urls are returned from "localhost:9222/json".
Browser tested:
Edge Version 136.0.3240.50
Chrome Version 136.0.7103.49
Fixes #61559