-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Add guidance for launching .NET apps from design proposal #49430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: agocke <[email protected]>
Co-authored-by: agocke <[email protected]>
Co-authored-by: agocke <[email protected]>
agocke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Please address comments
Co-authored-by: agocke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR integrates guidance for launching .NET framework-dependent applications directly into the main deployment documentation. The content, originally from a design proposal (dotnet/designs#346), explains the recommended approach of using the apphost executable over dotnet app.dll, detailing security benefits and runtime discovery mechanisms.
Key changes:
- Added subsection "Launch framework-dependent apps" explaining apphost advantages and runtime discovery
- Included
DOTNET_ROOTconfiguration best practices - Refined terminology and wording based on reviewer feedback
Co-authored-by: Jan Kotas <[email protected]>
Co-authored-by: jkotas <[email protected]>
Co-authored-by: jkotas <[email protected]>
Co-authored-by: jkotas <[email protected]>
Co-authored-by: jkotas <[email protected]>
Plan: Add guidance for launching .NET apps
Based on the problem statement, I need to:
Changes made:
Updated file:
docs/core/deploying/index.mdLatest change:
<PROJECT-FILE>and<PROJECT-NAME>) with lowercasemyappconvention throughout the document. This aligns with the naming convention used in other .NET documentation (e.g., docs/core/tools/dotnet-run.md uses "myapp.dll"). Changes made:<PROJECT-FILE>.exe→myapp.exeand<PROJECT-FILE>→myappdotnet <PROJECT-FILE>.dll→dotnet myapp.dll(2 instances)<PROJECT-NAME>.dll→myapp.dll(2 instances)Previous change:
Previous change:
Previous change:
Previous change:
Previous change:
Previous changes (addressing review feedback):
dotnet myapp.dll, which is still an acceptable way to run the app."Previous changes:
DOTNET_ROOTto set the runtime location for an app is to:" to "In general, the best practice for usingDOTNET_ROOTis to:" for concisenessPrevious integration:
Deleted file:
docs/core/deploying/net-app-launch.mdValidation completed:
Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Internal previews