From b9bda6532d8340ece77dbd0ed766616d08e8b52c Mon Sep 17 00:00:00 2001 From: carlossanlop Date: Wed, 14 Sep 2022 14:57:50 -0700 Subject: [PATCH 1/7] System.Runtime.InteropServices.Javascript RC1 --- .../JSException.xml | 6 +- .../JSExportAttribute.xml | 9 +- .../JSFunctionBinding.xml | 12 +- .../JSHost.xml | 17 +- .../JSImportAttribute.xml | 22 +- .../JSMarshalAsAttribute`1.xml | 7 +- ...rshalerArgument+ArgumentToJSCallback`1.xml | 3 +- ...erArgument+ArgumentToManagedCallback`1.xml | 3 +- .../JSMarshalerArgument.xml | 317 ++++++++++++------ .../JSMarshalerType.xml | 69 ++-- .../JSObject.xml | 48 +-- .../JSType+Any.xml | 2 +- .../JSType+Array`1.xml | 2 +- .../JSType+BigInt.xml | 2 +- .../JSType+Boolean.xml | 2 +- .../JSType+Date.xml | 2 +- .../JSType+Discard.xml | 2 +- .../JSType+Error.xml | 2 +- .../JSType+Function.xml | 2 +- .../JSType+Function`1.xml | 2 +- .../JSType+Function`2.xml | 2 +- .../JSType+Function`3.xml | 2 +- .../JSType+Function`4.xml | 2 +- .../JSType+MemoryView.xml | 2 +- .../JSType+Number.xml | 2 +- .../JSType+Object.xml | 2 +- .../JSType+Promise`1.xml | 2 +- .../JSType+String.xml | 2 +- .../JSType+Void.xml | 2 +- .../JSType.xml | 2 +- 30 files changed, 335 insertions(+), 216 deletions(-) diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSException.xml b/xml/System.Runtime.InteropServices.JavaScript/JSException.xml index bf989551d53..986a008af80 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSException.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSException.xml @@ -20,7 +20,7 @@ - To be added. + Represents an Exception initiated from the JavaScript interop code. To be added. @@ -40,8 +40,8 @@ - To be added. - To be added. + The message that describes the error. + Initializes a new instance of the JSException class with a specified error message. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml b/xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml index 97d1131f945..10843099bf3 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml @@ -24,8 +24,11 @@ - To be added. - To be added. + Attribute used to indicate a source generator should export a method to JavaScript and create thunks necessary to marshal its arguments along with any return value or thrown exception. + For marshaling arguments of complex types . + This attribute is meaningless if the source generator associated with it is not enabled. + The current built-in source generator only supports C# and only supplies an implementation when applied to static, non-partial, non-generic methods. + Exported methods cannot be trimmed by the linker. @@ -41,7 +44,7 @@ - To be added. + Initializes a new instance of the . To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSFunctionBinding.xml b/xml/System.Runtime.InteropServices.JavaScript/JSFunctionBinding.xml index d10e4c79ed1..f93048fc734 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSFunctionBinding.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSFunctionBinding.xml @@ -28,7 +28,8 @@ - To be added. + Represents a bound imported or exported JavaScript function and contains information necessary to invoke it. + This API supports JSImport infrastructure and is not intended to be used directly from your code. To be added. @@ -73,7 +74,8 @@ To be added. To be added. To be added. - To be added. + Locates and binds a JavaScript function given name and module so that it can later be invoked by managed callers. + This API supports JSImport infrastructure and is not intended to be used directly from your code. To be added. To be added. @@ -102,7 +104,8 @@ To be added. To be added. To be added. - To be added. + Binds a specific managed function wrapper so that it can later be invoked by JavaScript callers. + This API supports JSImport infrastructure and is not intended to be used directly from your code. To be added. To be added. @@ -129,7 +132,8 @@ To be added. To be added. - To be added. + Invokes a previously bound JavaScript function using the provided span to transport argument and return values. + This API supports JSImport infrastructure and is not intended to be used directly from your code. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSHost.xml b/xml/System.Runtime.InteropServices.JavaScript/JSHost.xml index e56d553aa8a..9e788b296d2 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSHost.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSHost.xml @@ -20,7 +20,7 @@ - To be added. + Represents the JavaScript host environment where the .NET runtime is currently operating. To be added. @@ -40,7 +40,7 @@ System.Runtime.InteropServices.JavaScript.JSObject - To be added. + Returns a proxy for the JavaScript module that contains the .NET runtime. To be added. To be added. @@ -61,7 +61,7 @@ System.Runtime.InteropServices.JavaScript.JSObject - To be added. + Returns a proxy for the globalThis JavaScript host object. To be added. To be added. @@ -86,11 +86,12 @@ - To be added. - To be added. - To be added. - To be added. - To be added. + Globally unique identifier of the ES6 module, which is used by . + The location of the module file. + The token to monitor for cancellation requests. + Download and instantiate an ES6 module from the provided URL, via the JavaScript host's dynamic import API. + If a module with the provided has previously been instantiated, it will be returned instead. + A proxy for the JavaScript object that contains the module's exports. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSImportAttribute.xml b/xml/System.Runtime.InteropServices.JavaScript/JSImportAttribute.xml index aeeb4162890..110884205b9 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSImportAttribute.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSImportAttribute.xml @@ -24,8 +24,10 @@ - To be added. - To be added. + Indicates that the JSImport source generator should create a managed wrapper to invoke a specific imported JavaScript function and marshal its arguments, return values, and exceptions. + To configure the marshaling behavior for specific values, . + This attribute is meaningless if the source generator associated with it is not enabled. + The current built-in source generator only supports C# and only supplies an implementation when applied to static, partial, non-generic methods. @@ -44,8 +46,8 @@ - To be added. - To be added. + Name of the function to be bound in the module. It allows dots for nested objects. + Initializes a new instance of the . To be added. @@ -66,9 +68,10 @@ - To be added. - To be added. - To be added. + The name of the target JavaScript function. This name will be used as a key to locate the function in the module. + Functions nested inside of objects can be referred to by using the dot operator to connect one or more names. + Globally unique identifier of the ES6 module, if any, that contains the function. The module must be loaded via before any attempt to invoke the function. + Initializes a new instance of the . To be added. @@ -88,7 +91,8 @@ System.String - To be added. + The name of the target JavaScript function. This name will be used as a key to locate the function in the module. + Functions nested inside of objects can be referred to by using the dot operator to connect one or more names. To be added. To be added. @@ -109,7 +113,7 @@ System.String - To be added. + Globally unique identifier of the ES6 module, if any, that contains the function. The module must be loaded via before any attempt to invoke the function. To be added. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalAsAttribute`1.xml b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalAsAttribute`1.xml index a490a51ddc1..b29eed5e3ba 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalAsAttribute`1.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalAsAttribute`1.xml @@ -31,8 +31,9 @@ - To be added. - To be added. + One of the types defined in , for example + Specifies the JavaScript type associated with a managed argument or return value. + The JSImport generator will use this information to marshal data between the JavaScript and managed environments. To be added. @@ -49,7 +50,7 @@ - To be added. + Create a configured by generic parameters of . To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToJSCallback`1.xml b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToJSCallback`1.xml index 794aa5820e6..7c86f7745a7 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToJSCallback`1.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToJSCallback`1.xml @@ -26,7 +26,8 @@ To be added. To be added. To be added. - To be added. + Helps with marshaling of the Task result or Function arguments. + It's used by JSImport code generator and should not be used by developers in source code. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToManagedCallback`1.xml b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToManagedCallback`1.xml index 461aa0b842e..c2a13b31828 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToManagedCallback`1.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToManagedCallback`1.xml @@ -26,7 +26,8 @@ To be added. To be added. To be added. - To be added. + Helps with marshaling of the Task result or Function arguments. + It's used by JSImport code generator and should not be used by developers in source code. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument.xml b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument.xml index 547eee8202c..4a792f3f86c 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument.xml @@ -28,7 +28,8 @@ - To be added. + Contains the storage and type information for an argument or return value on the native stack. + This API supports JSImport infrastructure and is not intended to be used directly from your code. To be added. @@ -49,7 +50,7 @@ - To be added. + This API supports JSImport infrastructure and is not intended to be used directly from your code. To be added. @@ -73,7 +74,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -97,7 +99,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -121,7 +124,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -145,7 +149,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -169,7 +174,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -193,7 +199,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -217,7 +224,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -241,7 +249,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -265,7 +274,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -289,7 +299,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -313,7 +324,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -337,7 +349,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -361,7 +374,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -385,7 +399,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -409,7 +424,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -433,7 +449,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -457,7 +474,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -481,7 +499,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -505,7 +524,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -529,7 +549,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -553,7 +574,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -577,7 +599,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -601,7 +624,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -625,7 +649,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -649,7 +674,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -673,7 +699,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -697,7 +724,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -721,7 +749,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -745,7 +774,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -769,7 +799,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -793,7 +824,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -817,7 +849,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -841,7 +874,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -865,7 +899,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -889,8 +924,9 @@ To be added. - To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. + caller is responsible for pinning @@ -913,8 +949,9 @@ To be added. - To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. + caller is responsible for pinning @@ -937,8 +974,9 @@ To be added. - To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. + caller is responsible for pinning @@ -961,7 +999,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -985,7 +1024,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1009,7 +1049,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1032,7 +1073,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1062,7 +1104,8 @@ To be added. To be added. To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1092,7 +1135,8 @@ To be added. To be added. To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1122,7 +1166,8 @@ To be added. To be added. To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1156,7 +1201,8 @@ To be added. To be added. To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1190,7 +1236,8 @@ To be added. To be added. To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1228,7 +1275,8 @@ To be added. To be added. To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1266,7 +1314,8 @@ To be added. To be added. To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1308,7 +1357,8 @@ To be added. To be added. To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1332,7 +1382,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1356,7 +1407,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1380,7 +1432,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1404,7 +1457,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1428,7 +1482,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1452,7 +1507,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1476,7 +1532,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1500,7 +1557,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1524,7 +1582,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1548,7 +1607,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1572,7 +1632,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1596,7 +1657,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1620,7 +1682,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1644,7 +1707,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1668,7 +1732,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1692,7 +1757,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1716,7 +1782,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1740,7 +1807,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1764,7 +1832,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1788,7 +1857,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1812,7 +1882,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1836,7 +1907,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1860,7 +1932,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1884,7 +1957,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1908,7 +1982,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1932,7 +2007,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1956,7 +2032,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1980,7 +2057,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2004,7 +2082,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2028,7 +2107,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2052,7 +2132,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2076,7 +2157,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2100,7 +2182,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2124,7 +2207,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2148,7 +2232,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2172,7 +2257,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2196,7 +2282,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2220,7 +2307,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2244,7 +2332,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2268,7 +2357,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2292,7 +2382,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2316,7 +2407,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2339,7 +2431,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2369,7 +2462,8 @@ To be added. To be added. To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2399,7 +2493,8 @@ To be added. To be added. To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2429,7 +2524,8 @@ To be added. To be added. To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2463,7 +2559,8 @@ To be added. To be added. To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2497,7 +2594,8 @@ To be added. To be added. To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2535,7 +2633,8 @@ To be added. To be added. To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2573,7 +2672,8 @@ To be added. To be added. To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2615,7 +2715,8 @@ To be added. To be added. To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2639,7 +2740,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2663,7 +2765,8 @@ To be added. - To be added. + Implementation of the argument marshaling. + It's used by JSImport code generator and should not be used by developers in source code. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerType.xml b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerType.xml index 1a95281d43d..529f569ee38 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerType.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerType.xml @@ -24,7 +24,8 @@ - To be added. + Represents type metadata about marshaler, which are necessary for marshaling function arguments. + It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -45,7 +46,7 @@ - To be added. + Marshal as JavaScript Function. To be added. To be added. @@ -70,7 +71,7 @@ To be added. - To be added. + Marshal as JavaScript Function. To be added. To be added. @@ -97,7 +98,7 @@ To be added. To be added. - To be added. + Marshal as JavaScript Function. To be added. To be added. @@ -126,7 +127,7 @@ To be added. To be added. To be added. - To be added. + Marshal as JavaScript Function. To be added. To be added. @@ -151,7 +152,7 @@ To be added. - To be added. + Marshal as JavaScript Array. To be added. To be added. @@ -176,9 +177,9 @@ To be added. - To be added. + Marshal as instance of ArraySegment class on JavaScript side. To be added. - To be added. + ArraySegment will hold to underlying array until disposed or garbage collected on JS side. @@ -197,7 +198,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - To be added. + Marshal as JavaScript BigInt. To be added. To be added. @@ -218,7 +219,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - To be added. + Marshal as JavaScript Boolean type. To be added. To be added. @@ -239,7 +240,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - To be added. + Marshal as JavaScript Number via Uint8Array. To be added. To be added. @@ -260,7 +261,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - To be added. + Marshal as JavaScript String one character long. To be added. To be added. @@ -281,7 +282,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - To be added. + Marshal as JavaScript Date. To be added. To be added. @@ -302,7 +303,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - To be added. + Marshal as JavaScript Date. To be added. To be added. @@ -323,7 +324,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - To be added. + Marshaling ignores result of the JavaScript function. To be added. To be added. @@ -344,7 +345,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - To be added. + Marshal as JavaScript Number. To be added. To be added. @@ -365,7 +366,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - To be added. + Marshal as JavaScript Error. To be added. To be added. @@ -390,7 +391,7 @@ To be added. - To be added. + Marshal as JavaScript Function. To be added. To be added. @@ -417,7 +418,7 @@ To be added. To be added. - To be added. + Marshal as JavaScript Function. To be added. To be added. @@ -446,7 +447,7 @@ To be added. To be added. To be added. - To be added. + Marshal as JavaScript Function. To be added. To be added. @@ -477,7 +478,7 @@ To be added. To be added. To be added. - To be added. + Marshal as JavaScript Function. To be added. To be added. @@ -498,7 +499,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - To be added. + Marshal as JavaScript Number via Int16Array. To be added. To be added. @@ -519,7 +520,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - To be added. + Marshal as JavaScript Number via Int32Array. To be added. To be added. @@ -540,7 +541,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - To be added. + Marshal as JavaScript Number within -9007199254740991 and 9007199254740991 range. To be added. To be added. @@ -561,7 +562,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - To be added. + Marshal as JavaScript Number. To be added. To be added. @@ -582,7 +583,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - To be added. + Marshal as JavaScript Object or it's JSObject proxy on managed side. To be added. To be added. @@ -628,7 +629,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - To be added. + Dynamic marshal as best fit. For maps to ManagedObject proxy on JavaScript side. To be added. To be added. @@ -649,7 +650,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - To be added. + Marshal as JavaScript Number. To be added. To be added. @@ -674,9 +675,9 @@ To be added. - To be added. + Marshal as instance of Span class on JavaScript side. To be added. - To be added. + Marshaler is not pinning the data, caller is responsible for doing that. @@ -695,7 +696,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - To be added. + Marshal as JavaScript String. To be added. To be added. @@ -717,7 +718,7 @@ - To be added. + Marshal as JavaScript Promise. To be added. To be added. @@ -742,7 +743,7 @@ To be added. - To be added. + Marshal as JavaScript Promise. To be added. To be added. @@ -763,7 +764,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - To be added. + Marshaling validates that the JavaScript function returned undefined value. To be added. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSObject.xml b/xml/System.Runtime.InteropServices.JavaScript/JSObject.xml index 13653660752..0cf69005b35 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSObject.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSObject.xml @@ -24,8 +24,8 @@ - To be added. - To be added. + Represents a reference to an object in the JavaScript host environment and enables interaction with it as a proxy. + JSObject instances are expensive, so use to release instances once you no longer need to retain a reference to the target object. @@ -72,9 +72,9 @@ To be added. - To be added. + Returns value of the property as if the property exists, otherwise . To be added. - To be added. + Will throw when the property value is not a bool. @@ -97,9 +97,9 @@ To be added. - To be added. + Returns value of the property as array if the property exists, otherwise . To be added. - To be added. + Will throw when the property value is not an array. @@ -122,9 +122,9 @@ To be added. - To be added. + Returns value of the property as if the property exists, otherwise 0. To be added. - To be added. + Will throw when the property value is not a number. @@ -147,9 +147,9 @@ To be added. - To be added. + Returns value of the property as if the property exists, otherwise 0. To be added. - To be added. + Will throw when the property value is not an integer. @@ -172,9 +172,9 @@ To be added. - To be added. + Returns value of the property as proxy if the property exists, otherwise . To be added. - To be added. + Will throw when the property value is not an object. @@ -197,9 +197,9 @@ To be added. - To be added. + Returns value of the property as if the property exists, otherwise . To be added. - To be added. + Will throw when the property value is not a string. @@ -222,7 +222,7 @@ To be added. - To be added. + Returns typeof() of the property. To be added. To be added. @@ -247,7 +247,7 @@ To be added. - To be added. + Checks whether the target object or one of its prototypes has a property with the specified name. To be added. To be added. @@ -268,7 +268,7 @@ System.Boolean - To be added. + Returns if the proxy was already disposed. To be added. To be added. @@ -295,7 +295,7 @@ To be added. To be added. - To be added. + Defines a new property on the target object, or modifies an existing property to have the specified value. To be added. @@ -321,8 +321,8 @@ To be added. To be added. - To be added. - To be added. + Defines a new property on the target object, or modifies an existing property to have the specified value. + The method will copy the bytes. @@ -347,7 +347,7 @@ To be added. To be added. - To be added. + Defines a new property on the target object, or modifies an existing property to have the specified value. To be added. @@ -373,7 +373,7 @@ To be added. To be added. - To be added. + Defines a new property on the target object, or modifies an existing property to have the specified value. To be added. @@ -399,7 +399,7 @@ To be added. To be added. - To be added. + Defines a new property on the target object, or modifies an existing property to have the specified value. To be added. @@ -425,7 +425,7 @@ To be added. To be added. - To be added. + Defines a new property on the target object, or modifies an existing property to have the specified value. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Any.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Any.xml index 151f75345e9..d3d7be52781 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Any.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Any.xml @@ -14,7 +14,7 @@ - To be added. + Dynamically selects the most appropriate JavaScript or managed type for each argument value at runtime. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Array`1.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Array`1.xml index 06b728e4f97..7635d1d3305 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Array`1.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Array`1.xml @@ -22,7 +22,7 @@ To be added. - To be added. + Marshal as copy of JavaScript Array or TypedArray type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+BigInt.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+BigInt.xml index f3ecabdbaf8..67a2d44a5c0 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+BigInt.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+BigInt.xml @@ -14,7 +14,7 @@ - To be added. + Marshal as JavaScript BigInt type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Boolean.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Boolean.xml index 5dec95550b0..8e0c9b0539c 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Boolean.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Boolean.xml @@ -14,7 +14,7 @@ - To be added. + Marshal as JavaScript Boolean type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Date.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Date.xml index ee7f2b1a9ab..c2ef1bb02b8 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Date.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Date.xml @@ -14,7 +14,7 @@ - To be added. + Marshal as JavaScript Date type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Discard.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Discard.xml index a4d509a21cd..e3f62cd0c4a 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Discard.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Discard.xml @@ -14,7 +14,7 @@ - To be added. + Suppresses marshaling of the JavaScript function's return value and discards it. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Error.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Error.xml index 836d94dc95c..137229e11c0 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Error.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Error.xml @@ -14,7 +14,7 @@ - To be added. + Marshal as JavaScript Error type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Function.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Function.xml index 5cdf6e59890..a9aaf0f077e 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Function.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Function.xml @@ -13,7 +13,7 @@ - To be added. + Marshal as JavaScript Function type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`1.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`1.xml index 50d5c915db7..4774bf63935 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`1.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`1.xml @@ -21,7 +21,7 @@ To be added. - To be added. + Marshal as JavaScript Function type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`2.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`2.xml index c668f08ec7b..64754103051 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`2.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`2.xml @@ -27,7 +27,7 @@ To be added. To be added. - To be added. + Marshal as JavaScript Function type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`3.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`3.xml index dfed4080f33..997a45371d3 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`3.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`3.xml @@ -33,7 +33,7 @@ To be added. To be added. To be added. - To be added. + Marshal as JavaScript Function type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`4.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`4.xml index ef81966f585..f0902c9d139 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`4.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`4.xml @@ -39,7 +39,7 @@ To be added. To be added. To be added. - To be added. + Marshal as JavaScript Function type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+MemoryView.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+MemoryView.xml index 7f6ce990923..a3016098c31 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+MemoryView.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+MemoryView.xml @@ -14,7 +14,7 @@ - To be added. + Marshals a managed Span or ArraySegment as a JavaScript wrapper object that provides access to the managed memory. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Number.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Number.xml index d35279d498b..1b3cbe50392 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Number.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Number.xml @@ -14,7 +14,7 @@ - To be added. + Marshal as JavaScript Number type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Object.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Object.xml index b72832896d1..02129032652 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Object.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Object.xml @@ -14,7 +14,7 @@ - To be added. + Marshal as JavaScript Object type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Promise`1.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Promise`1.xml index 89501fc8387..2a2b401f592 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Promise`1.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Promise`1.xml @@ -22,7 +22,7 @@ To be added. - To be added. + Marshal as JavaScript Promise type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+String.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+String.xml index 125e6e879c4..a570ce2d17c 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+String.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+String.xml @@ -14,7 +14,7 @@ - To be added. + Marshal as JavaScript String type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Void.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Void.xml index 9bb6e9d84eb..07c0118c860 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Void.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Void.xml @@ -14,7 +14,7 @@ - To be added. + Asserts that a JavaScript function should have no return value. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType.xml index 2bbac0727c3..7820e79da23 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType.xml @@ -20,7 +20,7 @@ - To be added. + Used as generic argument for to express expected JavaScript type, which should be source or result of argument marshaling. To be added. From 53a2b70c67b6f9ff9174652d64f03ca4b92e0523 Mon Sep 17 00:00:00 2001 From: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com> Date: Wed, 14 Sep 2022 16:41:36 -0700 Subject: [PATCH 2/7] First batch of suggestions by gewarren Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> --- .../JSExportAttribute.xml | 2 +- .../JSHost.xml | 4 ++-- .../JSImportAttribute.xml | 6 +++--- .../JSMarshalAsAttribute`1.xml | 4 ++-- .../JSMarshalerType.xml | 8 ++++---- .../JSObject.xml | 11 +++++++---- .../JSType+Any.xml | 2 +- .../JSType+Array`1.xml | 2 +- .../JSType+Error.xml | 2 +- .../JSType+Function.xml | 2 +- .../JSType+Function`1.xml | 2 +- .../JSType+Function`2.xml | 2 +- .../JSType+Function`3.xml | 2 +- .../JSType+Function`4.xml | 2 +- .../JSType+String.xml | 2 +- .../JSType.xml | 2 +- 16 files changed, 29 insertions(+), 26 deletions(-) diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml b/xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml index 10843099bf3..f7ba57b296b 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml @@ -24,7 +24,7 @@ - Attribute used to indicate a source generator should export a method to JavaScript and create thunks necessary to marshal its arguments along with any return value or thrown exception. + Indicates that a source generator should export the attributed method to JavaScript and create thunks necessary to marshal its arguments and any return value or thrown exception. For marshaling arguments of complex types . This attribute is meaningless if the source generator associated with it is not enabled. The current built-in source generator only supports C# and only supplies an implementation when applied to static, non-partial, non-generic methods. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSHost.xml b/xml/System.Runtime.InteropServices.JavaScript/JSHost.xml index 9e788b296d2..db6cda2bcef 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSHost.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSHost.xml @@ -61,7 +61,7 @@ System.Runtime.InteropServices.JavaScript.JSObject - Returns a proxy for the globalThis JavaScript host object. + Returns a proxy for the globalThis JavaScript host object. To be added. To be added. @@ -89,7 +89,7 @@ Globally unique identifier of the ES6 module, which is used by . The location of the module file. The token to monitor for cancellation requests. - Download and instantiate an ES6 module from the provided URL, via the JavaScript host's dynamic import API. + Downloads and instantiates an ES6 module from the provided URL, via the JavaScript host's dynamic import API. If a module with the provided has previously been instantiated, it will be returned instead. A proxy for the JavaScript object that contains the module's exports. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSImportAttribute.xml b/xml/System.Runtime.InteropServices.JavaScript/JSImportAttribute.xml index 110884205b9..5dfcf0738a5 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSImportAttribute.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSImportAttribute.xml @@ -71,7 +71,7 @@ The name of the target JavaScript function. This name will be used as a key to locate the function in the module. Functions nested inside of objects can be referred to by using the dot operator to connect one or more names. Globally unique identifier of the ES6 module, if any, that contains the function. The module must be loaded via before any attempt to invoke the function. - Initializes a new instance of the . + Initializes a new instance of the class. To be added. @@ -91,7 +91,7 @@ System.String - The name of the target JavaScript function. This name will be used as a key to locate the function in the module. + Gets the name of the target JavaScript function. This name will be used as a key to locate the function in the module. Functions nested inside of objects can be referred to by using the dot operator to connect one or more names. To be added. To be added. @@ -113,7 +113,7 @@ System.String - Globally unique identifier of the ES6 module, if any, that contains the function. The module must be loaded via before any attempt to invoke the function. + Gets the globally unique identifier of the ES6 module, if any, that contains the function. The module must be loaded via before any attempt to invoke the function. To be added. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalAsAttribute`1.xml b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalAsAttribute`1.xml index b29eed5e3ba..4b0e1c210df 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalAsAttribute`1.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalAsAttribute`1.xml @@ -31,7 +31,7 @@ - One of the types defined in , for example + One of the types defined in , for example . Specifies the JavaScript type associated with a managed argument or return value. The JSImport generator will use this information to marshal data between the JavaScript and managed environments. To be added. @@ -50,7 +50,7 @@ - Create a configured by generic parameters of . + Initializes a new instance of configured by generic parameters of . To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerType.xml b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerType.xml index 529f569ee38..a302568bb3b 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerType.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerType.xml @@ -24,7 +24,7 @@ - Represents type metadata about marshaler, which are necessary for marshaling function arguments. + Represents type metadata about the marshaller, which are necessary for marshalling function arguments. It's used by JSImport code generator and should not be used by developers in source code. To be added. @@ -179,7 +179,7 @@ To be added. Marshal as instance of ArraySegment class on JavaScript side. To be added. - ArraySegment will hold to underlying array until disposed or garbage collected on JS side. + ArraySegment will hold to underlying array until disposed or garbage-collected on JavaScript side. @@ -629,7 +629,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - Dynamic marshal as best fit. For maps to ManagedObject proxy on JavaScript side. + Dynamic marshal as best fit. For , maps to ManagedObject proxy on JavaScript side. To be added. To be added. @@ -764,7 +764,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - Marshaling validates that the JavaScript function returned undefined value. + Gets a value that indicates whether the JavaScript function returned an undefined value. To be added. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSObject.xml b/xml/System.Runtime.InteropServices.JavaScript/JSObject.xml index 0cf69005b35..19b7d834ee1 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSObject.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSObject.xml @@ -72,7 +72,7 @@ To be added. - Returns value of the property as if the property exists, otherwise . + Returns the value of the specified property as if the property exists, otherwise . To be added. Will throw when the property value is not a bool. @@ -97,7 +97,7 @@ To be added. - Returns value of the property as array if the property exists, otherwise . + Returns the value of the specified property as a array if the property exists, otherwise . To be added. Will throw when the property value is not an array. @@ -268,8 +268,11 @@ System.Boolean - Returns if the proxy was already disposed. - To be added. + Gets a value that indicates whether the proxy was already disposed. + + if the proxy was already disposed; otherwise, . To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Any.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Any.xml index d3d7be52781..000611ba607 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Any.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Any.xml @@ -14,7 +14,7 @@ - Dynamically selects the most appropriate JavaScript or managed type for each argument value at runtime. + Dynamically selects the most appropriate JavaScript or managed type for each argument value at run time. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Array`1.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Array`1.xml index 7635d1d3305..e42d886821d 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Array`1.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Array`1.xml @@ -22,7 +22,7 @@ To be added. - Marshal as copy of JavaScript Array or TypedArray type. + Marshals as a copy of the JavaScript Array or TypedArray type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Error.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Error.xml index 137229e11c0..673d0bd7485 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Error.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Error.xml @@ -14,7 +14,7 @@ - Marshal as JavaScript Error type. + Marshals as the JavaScript Error type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Function.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Function.xml index a9aaf0f077e..079798d3372 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Function.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Function.xml @@ -13,7 +13,7 @@ - Marshal as JavaScript Function type. + Marshals as the JavaScript Function type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`1.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`1.xml index 4774bf63935..eb12da637ca 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`1.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`1.xml @@ -21,7 +21,7 @@ To be added. - Marshal as JavaScript Function type. + Marshals as the JavaScript Function type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`2.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`2.xml index 64754103051..0c717ae7a54 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`2.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`2.xml @@ -27,7 +27,7 @@ To be added. To be added. - Marshal as JavaScript Function type. + Marshals as the JavaScript Function type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`3.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`3.xml index 997a45371d3..7a6242f8145 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`3.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`3.xml @@ -33,7 +33,7 @@ To be added. To be added. To be added. - Marshal as JavaScript Function type. + Marshals as the JavaScript Function type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`4.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`4.xml index f0902c9d139..123724f068e 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`4.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Function`4.xml @@ -39,7 +39,7 @@ To be added. To be added. To be added. - Marshal as JavaScript Function type. + Marshals as the JavaScript Function type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+String.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+String.xml index a570ce2d17c..609df72cac8 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+String.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+String.xml @@ -14,7 +14,7 @@ - Marshal as JavaScript String type. + Marshal as JavaScript String type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType.xml index 7820e79da23..ff570d434cb 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType.xml @@ -20,7 +20,7 @@ - Used as generic argument for to express expected JavaScript type, which should be source or result of argument marshaling. + Used as the generic argument for to express the expected JavaScript type, which should be the source or result of argument marshalling. To be added. From be2ed540f9e52a5ed0f522fad76747187b5fc946 Mon Sep 17 00:00:00 2001 From: carlossanlop Date: Wed, 14 Sep 2022 16:55:49 -0700 Subject: [PATCH 3/7] Next batch of suggestions by gewarren. --- .../JSException.xml | 2 +- .../JSExportAttribute.xml | 12 +++-- .../JSImportAttribute.xml | 15 +++--- .../JSMarshalerType.xml | 50 +++++++++---------- .../JSObject.xml | 22 ++++---- .../JSType+BigInt.xml | 2 +- .../JSType+Boolean.xml | 2 +- .../JSType+Date.xml | 2 +- .../JSType+Number.xml | 2 +- .../JSType+Object.xml | 2 +- .../JSType+Promise`1.xml | 2 +- 11 files changed, 60 insertions(+), 53 deletions(-) diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSException.xml b/xml/System.Runtime.InteropServices.JavaScript/JSException.xml index 986a008af80..647779ae81e 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSException.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSException.xml @@ -20,7 +20,7 @@ - Represents an Exception initiated from the JavaScript interop code. + Represents an exception initiated from the JavaScript interop code. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml b/xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml index f7ba57b296b..c2e33176f1f 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml @@ -24,11 +24,13 @@ - Indicates that a source generator should export the attributed method to JavaScript and create thunks necessary to marshal its arguments and any return value or thrown exception. - For marshaling arguments of complex types . - This attribute is meaningless if the source generator associated with it is not enabled. - The current built-in source generator only supports C# and only supplies an implementation when applied to static, non-partial, non-generic methods. - Exported methods cannot be trimmed by the linker. + Indicates that a source generator should export the attributed method to JavaScript and create thunks necessary to marshal its arguments and any return value or thrown exception. + + For marshaling arguments of complex types . + This attribute is meaningless if the source generator associated with it is not enabled. + The current built-in source generator only supports C# and only supplies an implementation when applied to static, non-partial, non-generic methods. + Exported methods cannot be trimmed by the linker. + diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSImportAttribute.xml b/xml/System.Runtime.InteropServices.JavaScript/JSImportAttribute.xml index 5dfcf0738a5..08ff2e771cc 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSImportAttribute.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSImportAttribute.xml @@ -24,10 +24,12 @@ - Indicates that the JSImport source generator should create a managed wrapper to invoke a specific imported JavaScript function and marshal its arguments, return values, and exceptions. - To configure the marshaling behavior for specific values, . - This attribute is meaningless if the source generator associated with it is not enabled. - The current built-in source generator only supports C# and only supplies an implementation when applied to static, partial, non-generic methods. + Indicates that the JSImport source generator should create a managed wrapper to invoke a specific imported JavaScript function and marshal its arguments, return values, and exceptions. + + To configure the marshaling behavior for specific values, . + This attribute is meaningless if the source generator associated with it is not enabled. + The current built-in source generator only supports C# and only supplies an implementation when applied to static, partial, non-generic methods. + @@ -91,10 +93,9 @@ System.String - Gets the name of the target JavaScript function. This name will be used as a key to locate the function in the module. - Functions nested inside of objects can be referred to by using the dot operator to connect one or more names. + Gets the name of the target JavaScript function. This name will be used as a key to locate the function in the module. To be added. - To be added. + Functions nested inside of objects can be referred to by using the dot operator to connect one or more names. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerType.xml b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerType.xml index a302568bb3b..dcb7bb4ccd8 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerType.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerType.xml @@ -46,7 +46,7 @@ - Marshal as JavaScript Function. + Marshal as JavaScript Function. To be added. To be added. @@ -71,7 +71,7 @@ To be added. - Marshal as JavaScript Function. + Marshal as JavaScript Function. To be added. To be added. @@ -98,7 +98,7 @@ To be added. To be added. - Marshal as JavaScript Function. + Marshal as JavaScript Function. To be added. To be added. @@ -127,7 +127,7 @@ To be added. To be added. To be added. - Marshal as JavaScript Function. + Marshal as JavaScript Function. To be added. To be added. @@ -152,7 +152,7 @@ To be added. - Marshal as JavaScript Array. + Marshal as JavaScript Array. To be added. To be added. @@ -198,7 +198,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - Marshal as JavaScript BigInt. + Marshal as JavaScript BigInt. To be added. To be added. @@ -219,7 +219,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - Marshal as JavaScript Boolean type. + Marshal as JavaScript Boolean type. To be added. To be added. @@ -240,7 +240,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - Marshal as JavaScript Number via Uint8Array. + Marshal as JavaScript Number via Uint8Array. To be added. To be added. @@ -261,7 +261,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - Marshal as JavaScript String one character long. + Marshal as JavaScript String one character long. To be added. To be added. @@ -282,7 +282,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - Marshal as JavaScript Date. + Marshal as JavaScript Date. To be added. To be added. @@ -303,7 +303,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - Marshal as JavaScript Date. + Marshal as JavaScript Date. To be added. To be added. @@ -345,7 +345,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - Marshal as JavaScript Number. + Marshal as JavaScript Number. To be added. To be added. @@ -366,7 +366,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - Marshal as JavaScript Error. + Marshal as JavaScript Error. To be added. To be added. @@ -391,7 +391,7 @@ To be added. - Marshal as JavaScript Function. + Marshal as JavaScript Function. To be added. To be added. @@ -418,7 +418,7 @@ To be added. To be added. - Marshal as JavaScript Function. + Marshal as JavaScript Function. To be added. To be added. @@ -447,7 +447,7 @@ To be added. To be added. To be added. - Marshal as JavaScript Function. + Marshal as JavaScript Function. To be added. To be added. @@ -478,7 +478,7 @@ To be added. To be added. To be added. - Marshal as JavaScript Function. + Marshal as JavaScript Function. To be added. To be added. @@ -499,7 +499,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - Marshal as JavaScript Number via Int16Array. + Marshal as JavaScript Number via Int16Array. To be added. To be added. @@ -520,7 +520,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - Marshal as JavaScript Number via Int32Array. + Marshal as JavaScript Number via Int32Array. To be added. To be added. @@ -562,7 +562,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - Marshal as JavaScript Number. + Marshal as JavaScript Number. To be added. To be added. @@ -583,7 +583,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - Marshal as JavaScript Object or it's JSObject proxy on managed side. + Marshal as JavaScript Object or it's JSObject proxy on managed side. To be added. To be added. @@ -650,7 +650,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - Marshal as JavaScript Number. + Marshal as JavaScript Number. To be added. To be added. @@ -696,7 +696,7 @@ System.Runtime.InteropServices.JavaScript.JSMarshalerType - Marshal as JavaScript String. + Marshal as JavaScript String. To be added. To be added. @@ -718,7 +718,7 @@ - Marshal as JavaScript Promise. + Marshal as JavaScript Promise. To be added. To be added. @@ -743,7 +743,7 @@ To be added. - Marshal as JavaScript Promise. + Marshal as JavaScript Promise. To be added. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSObject.xml b/xml/System.Runtime.InteropServices.JavaScript/JSObject.xml index 19b7d834ee1..8afb0e63cb2 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSObject.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSObject.xml @@ -74,7 +74,8 @@ To be added. Returns the value of the specified property as if the property exists, otherwise . To be added. - Will throw when the property value is not a bool. + To be added. + he property value is not a . @@ -99,7 +100,8 @@ To be added. Returns the value of the specified property as a array if the property exists, otherwise . To be added. - Will throw when the property value is not an array. + To be added. + The property value is not an array. @@ -124,7 +126,8 @@ To be added. Returns value of the property as if the property exists, otherwise 0. To be added. - Will throw when the property value is not a number. + To be added. + The property value is not a number. @@ -149,7 +152,8 @@ To be added. Returns value of the property as if the property exists, otherwise 0. To be added. - Will throw when the property value is not an integer. + To be added. + The property value is not an integer. @@ -174,7 +178,8 @@ To be added. Returns value of the property as proxy if the property exists, otherwise . To be added. - Will throw when the property value is not an object. + To be added. + The property value is not a . @@ -199,7 +204,8 @@ To be added. Returns value of the property as if the property exists, otherwise . To be added. - Will throw when the property value is not a string. + To be added. + The property value is not a string. @@ -270,9 +276,7 @@ Gets a value that indicates whether the proxy was already disposed. - if the proxy was already disposed; otherwise, . + if the proxy was already disposed; otherwise, . To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+BigInt.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+BigInt.xml index 67a2d44a5c0..6e23500042e 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+BigInt.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+BigInt.xml @@ -14,7 +14,7 @@ - Marshal as JavaScript BigInt type. + Marshal as JavaScript BigInt type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Boolean.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Boolean.xml index 8e0c9b0539c..d7b11581463 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Boolean.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Boolean.xml @@ -14,7 +14,7 @@ - Marshal as JavaScript Boolean type. + Marshal as JavaScript Boolean type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Date.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Date.xml index c2ef1bb02b8..e76e0e8259f 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Date.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Date.xml @@ -14,7 +14,7 @@ - Marshal as JavaScript Date type. + Marshal as JavaScript Date type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Number.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Number.xml index 1b3cbe50392..b0f56b46b99 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Number.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Number.xml @@ -14,7 +14,7 @@ - Marshal as JavaScript Number type. + Marshal as JavaScript Number type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Object.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Object.xml index 02129032652..2713a1f3179 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Object.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Object.xml @@ -14,7 +14,7 @@ - Marshal as JavaScript Object type. + Marshal as JavaScript Object type. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Promise`1.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Promise`1.xml index 2a2b401f592..d6e6f02c9f4 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Promise`1.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Promise`1.xml @@ -22,7 +22,7 @@ To be added. - Marshal as JavaScript Promise type. + Marshal as JavaScript Promise type. To be added. From 650a6413afe9d36276308def993568d0f3a542a2 Mon Sep 17 00:00:00 2001 From: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com> Date: Wed, 14 Sep 2022 17:59:38 -0700 Subject: [PATCH 4/7] Apply suggestions from code review --- xml/System.Runtime.InteropServices.JavaScript/JSObject.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSObject.xml b/xml/System.Runtime.InteropServices.JavaScript/JSObject.xml index 8afb0e63cb2..e45e45acfdc 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSObject.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSObject.xml @@ -75,7 +75,7 @@ Returns the value of the specified property as if the property exists, otherwise . To be added. To be added. - he property value is not a . + he property value is not a . From a5985ecb8780a92ecde00fe39dc5b073b9410001 Mon Sep 17 00:00:00 2001 From: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Date: Wed, 14 Sep 2022 21:03:09 -0700 Subject: [PATCH 5/7] It's -> This API is --- .../JSMarshalerArgument.xml | 204 +++++++++--------- 1 file changed, 102 insertions(+), 102 deletions(-) diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument.xml b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument.xml index 4a792f3f86c..1c4c3b8d930 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument.xml @@ -75,7 +75,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -100,7 +100,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is by JSImport code generator and should not be used by developers in source code. To be added. @@ -125,7 +125,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is by JSImport code generator and should not be used by developers in source code. To be added. @@ -150,7 +150,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is by JSImport code generator and should not be used by developers in source code. To be added. @@ -175,7 +175,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is by JSImport code generator and should not be used by developers in source code. To be added. @@ -200,7 +200,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is by JSImport code generator and should not be used by developers in source code. To be added. @@ -225,7 +225,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is by JSImport code generator and should not be used by developers in source code. To be added. @@ -250,7 +250,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is by JSImport code generator and should not be used by developers in source code. To be added. @@ -275,7 +275,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is by JSImport code generator and should not be used by developers in source code. To be added. @@ -300,7 +300,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is by JSImport code generator and should not be used by developers in source code. To be added. @@ -325,7 +325,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is by JSImport code generator and should not be used by developers in source code. To be added. @@ -350,7 +350,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is by JSImport code generator and should not be used by developers in source code. To be added. @@ -375,7 +375,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is by JSImport code generator and should not be used by developers in source code. To be added. @@ -400,7 +400,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is by JSImport code generator and should not be used by developers in source code. To be added. @@ -425,7 +425,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is by JSImport code generator and should not be used by developers in source code. To be added. @@ -450,7 +450,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is by JSImport code generator and should not be used by developers in source code. To be added. @@ -475,7 +475,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is by JSImport code generator and should not be used by developers in source code. To be added. @@ -500,7 +500,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is by JSImport code generator and should not be used by developers in source code. To be added. @@ -525,7 +525,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is by JSImport code generator and should not be used by developers in source code. To be added. @@ -550,7 +550,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is by JSImport code generator and should not be used by developers in source code. To be added. @@ -575,7 +575,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is by JSImport code generator and should not be used by developers in source code. To be added. @@ -600,7 +600,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -625,7 +625,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -650,7 +650,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -675,7 +675,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -700,7 +700,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -725,7 +725,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -750,7 +750,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -775,7 +775,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -800,7 +800,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -825,7 +825,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -850,7 +850,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -875,7 +875,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -900,7 +900,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -925,7 +925,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. caller is responsible for pinning @@ -950,7 +950,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. caller is responsible for pinning @@ -975,7 +975,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. caller is responsible for pinning @@ -1000,7 +1000,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1025,7 +1025,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1050,7 +1050,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1074,7 +1074,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1105,7 +1105,7 @@ To be added. To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1136,7 +1136,7 @@ To be added. To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1167,7 +1167,7 @@ To be added. To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1202,7 +1202,7 @@ To be added. To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1237,7 +1237,7 @@ To be added. To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1276,7 +1276,7 @@ To be added. To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1315,7 +1315,7 @@ To be added. To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1358,7 +1358,7 @@ To be added. To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1383,7 +1383,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1408,7 +1408,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1433,7 +1433,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1458,7 +1458,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1483,7 +1483,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1508,7 +1508,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1533,7 +1533,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1558,7 +1558,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1583,7 +1583,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1608,7 +1608,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1633,7 +1633,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1658,7 +1658,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1683,7 +1683,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1708,7 +1708,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1733,7 +1733,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1758,7 +1758,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1783,7 +1783,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1808,7 +1808,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1833,7 +1833,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1858,7 +1858,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1883,7 +1883,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1908,7 +1908,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1933,7 +1933,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1958,7 +1958,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -1983,7 +1983,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2008,7 +2008,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2033,7 +2033,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2058,7 +2058,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2083,7 +2083,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2108,7 +2108,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2133,7 +2133,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2158,7 +2158,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2183,7 +2183,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2208,7 +2208,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2233,7 +2233,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2258,7 +2258,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2283,7 +2283,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2308,7 +2308,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2333,7 +2333,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2358,7 +2358,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2383,7 +2383,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2408,7 +2408,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2432,7 +2432,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2463,7 +2463,7 @@ To be added. To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2494,7 +2494,7 @@ To be added. To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2525,7 +2525,7 @@ To be added. To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2560,7 +2560,7 @@ To be added. To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2595,7 +2595,7 @@ To be added. To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2634,7 +2634,7 @@ To be added. To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2673,7 +2673,7 @@ To be added. To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2716,7 +2716,7 @@ To be added. To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2741,7 +2741,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. @@ -2766,7 +2766,7 @@ To be added. Implementation of the argument marshaling. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. From 5c7d4003a2d1b9fffbe445d5c6df6842e8c6097f Mon Sep 17 00:00:00 2001 From: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com> Date: Thu, 15 Sep 2022 08:30:41 -0700 Subject: [PATCH 6/7] Apply suggestions from code review Co-authored-by: Ankit Jain Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> --- .../JSExportAttribute.xml | 2 +- .../JSImportAttribute.xml | 6 +++--- .../JSMarshalerArgument+ArgumentToJSCallback`1.xml | 4 ++-- .../JSMarshalerArgument+ArgumentToManagedCallback`1.xml | 4 ++-- .../JSMarshalerType.xml | 2 +- .../JSType+Discard.xml | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml b/xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml index c2e33176f1f..7f74588eb07 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml @@ -46,7 +46,7 @@ - Initializes a new instance of the . + Initializes a new instance of the class. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSImportAttribute.xml b/xml/System.Runtime.InteropServices.JavaScript/JSImportAttribute.xml index 08ff2e771cc..96b230ac11b 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSImportAttribute.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSImportAttribute.xml @@ -26,7 +26,7 @@ Indicates that the JSImport source generator should create a managed wrapper to invoke a specific imported JavaScript function and marshal its arguments, return values, and exceptions. - To configure the marshaling behavior for specific values, . + To configure the marshalling behavior for specific values, . This attribute is meaningless if the source generator associated with it is not enabled. The current built-in source generator only supports C# and only supplies an implementation when applied to static, partial, non-generic methods. @@ -48,8 +48,8 @@ - Name of the function to be bound in the module. It allows dots for nested objects. - Initializes a new instance of the . + The name of the function to be bound in the module. Use dots for nested objects. + Initializes a new instance of the class. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToJSCallback`1.xml b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToJSCallback`1.xml index 7c86f7745a7..bf34700a154 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToJSCallback`1.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToJSCallback`1.xml @@ -26,8 +26,8 @@ To be added. To be added. To be added. - Helps with marshaling of the Task result or Function arguments. - It's used by JSImport code generator and should not be used by developers in source code. + Assists in marshalling of Task results and Function arguments. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToManagedCallback`1.xml b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToManagedCallback`1.xml index c2a13b31828..21fc2b3b505 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToManagedCallback`1.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToManagedCallback`1.xml @@ -26,8 +26,8 @@ To be added. To be added. To be added. - Helps with marshaling of the Task result or Function arguments. - It's used by JSImport code generator and should not be used by developers in source code. + Assists in marshalling of Task results and Function arguments. + This API is used by JSImport code generator and should not be used by developers in source code. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerType.xml b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerType.xml index dcb7bb4ccd8..e7645282f2e 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerType.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerType.xml @@ -25,7 +25,7 @@ Represents type metadata about the marshaller, which are necessary for marshalling function arguments. - It's used by JSImport code generator and should not be used by developers in source code. + This API is used by the JSImport code generator and should not be used by developers in source code. To be added. diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSType+Discard.xml b/xml/System.Runtime.InteropServices.JavaScript/JSType+Discard.xml index e3f62cd0c4a..1425a45d3e9 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSType+Discard.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSType+Discard.xml @@ -14,7 +14,7 @@ - Suppresses marshaling of the JavaScript function's return value and discards it. + Suppresses marshalling of the JavaScript function's return value and discards it. To be added. From 939a28efab5f5e7d9c67c325909d203af25e83e0 Mon Sep 17 00:00:00 2001 From: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com> Date: Thu, 15 Sep 2022 08:33:21 -0700 Subject: [PATCH 7/7] Update xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml Co-authored-by: Ankit Jain --- .../JSExportAttribute.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml b/xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml index 7f74588eb07..caabc6660da 100644 --- a/xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml +++ b/xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml @@ -28,7 +28,7 @@ For marshaling arguments of complex types . This attribute is meaningless if the source generator associated with it is not enabled. - The current built-in source generator only supports C# and only supplies an implementation when applied to static, non-partial, non-generic methods. + The current built-in source generator only supports C# and only supplies an implementation when applied to static, non-partial, or non-generic methods. Exported methods cannot be trimmed by the linker.