Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 70b6932

Browse files
mattleibowrmarinhoCopilotPureWeen
committed
Update the comment for the test properties (#27306)
* Update the comment for the test properties * Apply suggestions from code review Co-authored-by: Copilot <[email protected]> * Update src/TestUtils/src/Microsoft.Maui.IntegrationTests/BaseBuildTest.cs Co-authored-by: Rui Marinho <[email protected]> * Update src/TestUtils/src/Microsoft.Maui.IntegrationTests/BaseBuildTest.cs * Update BaseBuildTest.cs --------- Co-authored-by: Rui Marinho <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Shane Neuville <[email protected]>
1 parent 5860fe6 commit 70b6932

File tree

1 file changed

+15
-2
lines changed

1 file changed

+15
-2
lines changed

src/TestUtils/src/Microsoft.Maui.IntegrationTests/BaseBuildTest.cs

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,21 @@ public abstract class BaseBuildTest
1313
public const string DotNetCurrent = "net9.0";
1414
public const string DotNetPrevious = "net8.0";
1515

16-
public const string MauiVersionCurrent = "9.0.0-rc.1.24453.9"; // this should not be the same as the last release
17-
public const string MauiVersionPrevious = "8.0.72"; // this should not be the same version as the default. aka: MicrosoftMauiPreviousDotNetReleasedVersion in eng/Versions.props
16+
// Versions of .NET MAUI that are used when testing the <MauiVersion> property. These should preferrably
17+
// different to the defaults in the SDKs such that the tests can test what would happen if the user puts
18+
// some arbitrary number in <MauiVersion>. The actual numbers do not matter as much, as long as they trigger
19+
// the MSBuild targets that would download some version that is only on nuget.org and not in the workload.
20+
//
21+
// MauiVersionCurrent: this should be the current .NET version of MAUI, but the latest released build.
22+
// For example, if this branch is for .NET 9, then this must be a 9.0.x number. If the latest MAUI release
23+
// is 9.0.100, then this should preferrable be some older build to make sure things work, like 9.0.30.
24+
public const string MauiVersionCurrent = "9.0.14";
25+
// MauiVersionPrevious: this should be the previous .NET version of MAUI.
26+
// For example, if this branch is for .NET 9, then this must be a 8.0.x number, but should preferrably
27+
// not be the same as the default in MicrosoftMauiPreviousDotNetReleasedVersion in eng/Versions.props
28+
// as this would result in the tests not testing anything. If the .NET 9 version of MAUI pulls in 8.0.100
29+
// of the .NET 8 MAUI, then this should be 8.0.80 for example.
30+
public const string MauiVersionPrevious = "8.0.93";
1831

1932
char[] invalidChars = { '{', '}', '(', ')', '$', ':', ';', '\"', '\'', ',', '=', '.', '-', ' ', };
2033

0 commit comments

Comments
 (0)