Add an IsKnownConstant path to SinCos

tannergooding · tannergooding · commit 1fc86b5baeff · 2024-06-19T12:58:16.000-07:00
diff --git a/src/coreclr/System.Private.CoreLib/src/System/Math.CoreCLR.cs b/src/coreclr/System.Private.CoreLib/src/System/Math.CoreCLR.cs
@@ -95,6 +95,11 @@ public static partial class Math
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static unsafe (double Sin, double Cos) SinCos(double x)
         {
+            if (RuntimeHelpers.IsKnownConstant(x))
+            {
+                return (Sin(x), Cos(x));
+            }
+
             double sin, cos;
             SinCos(x, &sin, &cos);
             return (sin, cos);
@@ -119,6 +124,7 @@ public static unsafe (double Sin, double Cos) SinCos(double x)
         [MethodImpl(MethodImplOptions.InternalCall)]
         private static extern unsafe double ModF(double x, double* intptr);
 
+        [Intrinsic]
         [MethodImpl(MethodImplOptions.InternalCall)]
         private static extern unsafe void SinCos(double x, double* sin, double* cos);
     }
diff --git a/src/coreclr/System.Private.CoreLib/src/System/MathF.CoreCLR.cs b/src/coreclr/System.Private.CoreLib/src/System/MathF.CoreCLR.cs
@@ -92,6 +92,11 @@ public static partial class MathF
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static unsafe (float Sin, float Cos) SinCos(float x)
         {
+            if (RuntimeHelpers.IsKnownConstant(x))
+            {
+                return (Sin(x), Cos(x));
+            }
+
             float sin, cos;
             SinCos(x, &sin, &cos);
             return (sin, cos);
@@ -116,6 +121,7 @@ public static unsafe (float Sin, float Cos) SinCos(float x)
         [MethodImpl(MethodImplOptions.InternalCall)]
         private static extern unsafe float ModF(float x, float* intptr);
 
+        [Intrinsic]
         [MethodImpl(MethodImplOptions.InternalCall)]
         private static extern unsafe void SinCos(float x, float* sin, float* cos);
     }
